Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 08:38:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Better lifecycle handling (#242758)

Browse Source 
I moved to a factory model because there was just so much that needed to be async.

I think the amount of async code will be reduced in the future as we remove some migration logic, but this makes sure we don't accidentally create instances without awaiting their initialization.
This commit is contained in:
Tyler James Leonhardt
2025-03-05 17:50:14 -08:00
committed by GitHub
parent 0664c2e142
commit eab6f90c72
7 changed files with 137 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/microsoft-authentication/src/common/publicClientCache.ts
View File

@@ -5,8 +5,7 @@
import type { AccountInfo, AuthenticationResult, InteractiveRequest, RefreshTokenRequest, SilentFlowRequest } from '@azure/msal-node';
import type { Disposable, Event } from 'vscode';
export interface ICachedPublicClientApplication extends Disposable {
initialize(): Promise<void>;
export interface ICachedPublicClientApplication {
onDidAccountsChange: Event<{ added: AccountInfo[]; changed: AccountInfo[]; deleted: AccountInfo[] }>;
onDidRemoveLastAccount: Event<void>;
acquireTokenSilent(request: SilentFlowRequest): Promise<AuthenticationResult>;