From eabb747d82c45ecfb074dd4a63df2d3be23adbbf Mon Sep 17 00:00:00 2001 From: Eric Amodio Date: Wed, 23 Sep 2020 15:56:37 -0400 Subject: [PATCH] Closes #105667 - finalizes treeview description --- src/vs/vscode.d.ts | 6 ++++++ src/vs/vscode.proposed.d.ts | 11 ----------- src/vs/workbench/api/common/extHostTreeViews.ts | 2 -- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts index df6fe60afc8..4186a551efc 100644 --- a/src/vs/vscode.d.ts +++ b/src/vs/vscode.d.ts @@ -8599,6 +8599,12 @@ declare module 'vscode' { */ title?: string; + /** + * An optional human-readable description which is rendered less prominently in the title of the view. + * Setting the title description to null, undefined, or empty string will remove the description from the view. + */ + description?: string; + /** * Reveals the given element in the tree view. * If the tree view is not visible then the tree view is shown and element is revealed. diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index b03ecd6d07a..7bd4e8fc480 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -2156,17 +2156,6 @@ declare module 'vscode' { //#endregion - //#region https://github.com/microsoft/vscode/issues/105667 - - export interface TreeView { - /** - * An optional human-readable description that will be rendered in the title of the view. - * Setting the title description to null, undefined, or empty string will remove the title description from the view. - */ - description?: string | undefined; - } - //#endregion - //#region https://github.com/microsoft/vscode/issues/103120 @alexr00 export class ThemeIcon2 extends ThemeIcon { diff --git a/src/vs/workbench/api/common/extHostTreeViews.ts b/src/vs/workbench/api/common/extHostTreeViews.ts index bc284a4f34c..7a2ee152b24 100644 --- a/src/vs/workbench/api/common/extHostTreeViews.ts +++ b/src/vs/workbench/api/common/extHostTreeViews.ts @@ -102,11 +102,9 @@ export class ExtHostTreeViews implements ExtHostTreeViewsShape { treeView.title = title; }, get description() { - checkProposedApiEnabled(extension); return treeView.description; }, set description(description: string | undefined) { - checkProposedApiEnabled(extension); treeView.description = description; }, reveal: (element: T, options?: IRevealOptions): Promise => {