From 6fba44510b9b357baea20fc7804edbb94d91a8ab Mon Sep 17 00:00:00 2001 From: Laurent Le Brun Date: Thu, 6 Oct 2022 16:30:01 +0200 Subject: [PATCH 1/2] Update column names in 'Feature Contributions' - Use "ID" for the setting. "ID" is the term used in the settings editor. - Use "ID" / "Title" instead of "Name" / "Description" for commands. They are the terms used in the keybinding editor and other places. - Use "ID" instead of "Id" everywhere for consistency --- .../contrib/extensions/browser/extensionEditor.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts index 65d0cc03d7e..f9c660594e0 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts @@ -1197,7 +1197,7 @@ export class ExtensionEditor extends EditorPane { $('summary', { tabindex: '0' }, localize('settings', "Settings ({0})", contrib.length)), $('table', undefined, $('tr', undefined, - $('th', undefined, localize('setting name', "Name")), + $('th', undefined, localize('setting name', "ID")), $('th', undefined, localize('description', "Description")), $('th', undefined, localize('default', "Default")) ), @@ -1378,7 +1378,7 @@ export class ExtensionEditor extends EditorPane { $('table', undefined, $('tr', undefined, $('th', undefined, localize('authentication.label', "Label")), - $('th', undefined, localize('authentication.id', "Id")) + $('th', undefined, localize('authentication.id', "ID")) ), ...authentication.map(action => $('tr', undefined, @@ -1460,7 +1460,7 @@ export class ExtensionEditor extends EditorPane { $('summary', { tabindex: '0' }, localize('colors', "Colors ({0})", colors.length)), $('table', undefined, $('tr', undefined, - $('th', undefined, localize('colorId', "Id")), + $('th', undefined, localize('colorId', "ID")), $('th', undefined, localize('description', "Description")), $('th', undefined, localize('defaultDark', "Dark Default")), $('th', undefined, localize('defaultLight', "Light Default")), @@ -1566,8 +1566,8 @@ export class ExtensionEditor extends EditorPane { $('summary', { tabindex: '0' }, localize('commands', "Commands ({0})", commands.length)), $('table', undefined, $('tr', undefined, - $('th', undefined, localize('command name', "Name")), - $('th', undefined, localize('description', "Description")), + $('th', undefined, localize('command name', "ID")), + $('th', undefined, localize('description', "Title")), $('th', undefined, localize('keyboard shortcuts', "Keyboard Shortcuts")), $('th', undefined, localize('menuContexts', "Menu Contexts")) ), @@ -1677,7 +1677,7 @@ export class ExtensionEditor extends EditorPane { $('summary', { tabindex: '0' }, localize('Notebooks', "Notebooks ({0})", contrib.length)), $('table', undefined, $('tr', undefined, - $('th', undefined, localize('Notebook id', "Id")), + $('th', undefined, localize('Notebook id', "ID")), $('th', undefined, localize('Notebook name', "Name")), ), ...contrib.map(d => $('tr', undefined, From 25e8bbbdc924dd2de929cd85869cd69a0a0b6821 Mon Sep 17 00:00:00 2001 From: Laurent Le Brun Date: Thu, 6 Oct 2022 18:30:25 +0200 Subject: [PATCH 2/2] update localize info to fix linter issue --- src/vs/workbench/contrib/extensions/browser/extensionEditor.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts index f9c660594e0..ba6774dd3f9 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts @@ -1567,7 +1567,7 @@ export class ExtensionEditor extends EditorPane { $('table', undefined, $('tr', undefined, $('th', undefined, localize('command name', "ID")), - $('th', undefined, localize('description', "Title")), + $('th', undefined, localize('command title', "Title")), $('th', undefined, localize('keyboard shortcuts', "Keyboard Shortcuts")), $('th', undefined, localize('menuContexts', "Menu Contexts")) ),