From eafba8ce2e8f8ed2087c04e2aa162e4634aa4d71 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 16 Jun 2021 05:00:34 -0700 Subject: [PATCH] Fix exception when moving from terminal editor to view --- src/vs/workbench/contrib/terminal/browser/terminalInstance.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 292d3e55658..87ccf9219c8 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -647,7 +647,9 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { } // The container changed, reattach - this._container?.removeChild(this._wrapperElement); + const wrapperElement = this._wrapperElement; + this.detachFromElement(); + this._wrapperElement = wrapperElement; this._container = container; this._container.appendChild(this._wrapperElement); setTimeout(() => this._initDragAndDrop(container));