From eb3ee0b36f69d24e1e9f8e19cd5f0cb6d76059bd Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Mon, 15 Jun 2020 14:39:13 +0200 Subject: [PATCH] ipc - properly remove vscode:exit raw ipc --- src/vs/code/electron-main/app.ts | 7 ------- .../test/electron-browser/workbenchTestServices.ts | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/vs/code/electron-main/app.ts b/src/vs/code/electron-main/app.ts index 32f3bb2e808..dcd5d03f330 100644 --- a/src/vs/code/electron-main/app.ts +++ b/src/vs/code/electron-main/app.ts @@ -261,13 +261,6 @@ export class CodeApplication extends Disposable { } }); - ipc.on('vscode:exit', (event: Event, code: number) => { - this.logService.trace('IPC#vscode:exit', code); - - this.dispose(); - this.lifecycleMainService.kill(code); - }); - ipc.on('vscode:fetchShellEnv', async (event: IpcMainEvent) => { const webContents = event.sender; diff --git a/src/vs/workbench/test/electron-browser/workbenchTestServices.ts b/src/vs/workbench/test/electron-browser/workbenchTestServices.ts index a080fba7091..a23649eb9a2 100644 --- a/src/vs/workbench/test/electron-browser/workbenchTestServices.ts +++ b/src/vs/workbench/test/electron-browser/workbenchTestServices.ts @@ -217,6 +217,7 @@ export class TestElectronService implements IElectronService { async closeWindow(): Promise { } async closeWindowById(): Promise { } async quit(): Promise { } + async exit(code: number): Promise { } async openDevTools(options?: Electron.OpenDevToolsOptions | undefined): Promise { } async toggleDevTools(): Promise { } async startCrashReporter(options: Electron.CrashReporterStartOptions): Promise { }