From 405ee65e17454608d4540bb1abd71922a243398b Mon Sep 17 00:00:00 2001 From: xzper Date: Tue, 5 Jul 2016 13:26:48 +0800 Subject: [PATCH] Fix did not removed css class dropfeedback --- .../browser/parts/editor/sideBySideEditorControl.ts | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/browser/parts/editor/sideBySideEditorControl.ts b/src/vs/workbench/browser/parts/editor/sideBySideEditorControl.ts index 421dfd17da4..16bab112c29 100644 --- a/src/vs/workbench/browser/parts/editor/sideBySideEditorControl.ts +++ b/src/vs/workbench/browser/parts/editor/sideBySideEditorControl.ts @@ -984,20 +984,27 @@ export class SideBySideEditorControl implements ISideBySideEditorControl, IVerti if (e.target === node) { DOM.EventHelper.stop(e, true); onDrop(e, Position.LEFT); + } else { + DOM.removeClass(node, 'dropfeedback'); } })); // Drag over this.toDispose.push(DOM.addDisposableListener(node, DOM.EventType.DRAG_OVER, (e: DragEvent) => { - DOM.addClass(node, 'dropfeedback'); + if (e.target === node) { + DOM.addClass(node, 'dropfeedback'); + } const target = e.target; if (target) { if (overlay && target.id !== overlayId) { destroyOverlay(); // somehow we managed to move the mouse quickly out of the current overlay, so destroy it } - createOverlay(target); + + if (overlay) { + DOM.addClass(node, 'dropfeedback'); + } } })); @@ -1655,4 +1662,4 @@ export class SideBySideEditorControl implements ISideBySideEditorControl, IVerti this._onGroupFocusChanged.dispose(); } -} \ No newline at end of file +}