Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix #145111

Browse Source
This commit is contained in:
Logan Ramos
2022-03-15 09:55:57 -04:00
parent 037fd05f03
commit ed5a545047
5 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/workbench/api/common/extHost.protocol.ts
View File

@@ -612,7 +612,7 @@ export interface ExtHostEditorInsetsShape {
export interface MainThreadEditorTabsShape extends IDisposable {
// manage tabs: move, close, rearrange etc
$moveTab(tab: IEditorTabDto, index: number, viewColumn: EditorGroupColumn): void;
$closeTab(tab: IEditorTabDto): Promise<void>;
$closeTab(tab: IEditorTabDto, preserveFocus: boolean): Promise<void>;
}
export interface IEditorTabGroupDto {

8
src/vs/workbench/api/common/extHostEditorTabs.ts
View File

@@ -22,7 +22,7 @@ export interface IEditorTab {
isDirty: boolean;
additionalResourcesAndViewTypes: { resource: vscode.Uri | undefined; viewType: string | undefined }[];
move(index: number, viewColumn: ViewColumn): Promise<void>;
close(): Promise<void>;
close(preserveFocus: boolean): Promise<void>;
}
export interface IEditorTabGroup {
@@ -122,13 +122,11 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
move: async (index: number, viewColumn: ViewColumn) => {
this._proxy.$moveTab(tabDto, index, typeConverters.ViewColumn.from(viewColumn));
// TODO: Need an on did change tab event at the group level
// await raceTimeout(Event.toPromise(this._onDidChangeTabs.event), 1000);
return;
},
close: async () => {
await this._proxy.$closeTab(tabDto);
close: async (preserveFocus) => {
await this._proxy.$closeTab(tabDto, preserveFocus);
// TODO: Need an on did change tab event at the group level
// await raceTimeout(Event.toPromise(this._onDidChangeTabs.event), 1000);
return;
}
});