From ede8a0f336d86f530077d5c0509f01c8eac947f9 Mon Sep 17 00:00:00 2001 From: Christof Marti Date: Thu, 21 Jun 2018 11:42:40 +0200 Subject: [PATCH] Copy extension-provided arrays (#49340) --- src/vs/workbench/api/node/extHostQuickOpen.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/api/node/extHostQuickOpen.ts b/src/vs/workbench/api/node/extHostQuickOpen.ts index 1673e4b4876..a6ad6b4014c 100644 --- a/src/vs/workbench/api/node/extHostQuickOpen.ts +++ b/src/vs/workbench/api/node/extHostQuickOpen.ts @@ -325,7 +325,7 @@ class ExtHostQuickInput implements QuickInput { } set buttons(buttons: QuickInputButton[]) { - this._buttons = buttons; + this._buttons = buttons.slice(); this._handlesToButtons.clear(); buttons.forEach((button, i) => { const handle = button === backButton ? -1 : i; @@ -478,7 +478,7 @@ class ExtHostQuickPick extends ExtHostQuickInput implements QuickPick { } set items(items: QuickPickItem[]) { - this._items = items; + this._items = items.slice(); this._handlesToItems.clear(); this._itemsToHandles.clear(); items.forEach((item, i) => {