Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Simplify git clone API (#272912)

Browse Source 
- Don't allow to skip the cache
- Only have "none" post commit action
- Consolidate post commit logic
- I ended up keeping the `Uri | null` return type for the `clone` API. It's just too useful, and there's no reason why we couldn't pass it back if the user didn't decide to open the clone and reload the window.
This commit is contained in:
Alex Ross
2025-10-23 16:55:21 +02:00
committed by GitHub
parent 3cc447e709
commit edf4ea5879
3 changed files with 76 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/git/src/api/api1.ts
View File

@@ -395,6 +395,11 @@ export class ApiImpl implements API {
}
}
async getRepositoryWorkspace(uri: Uri): Promise<Uri[] | null> {
const workspaces = this.#model.repositoryCache.get(uri.toString());
return workspaces ? workspaces.map(r => Uri.file(r.workspacePath)) : null;
}
async init(root: Uri, options?: InitOptions): Promise<Repository | null> {
const path = root.fsPath;
await this.#model.git.init(path, options);
@@ -404,7 +409,7 @@ export class ApiImpl implements API {
async clone(uri: Uri, options?: CloneOptions): Promise<Uri | null> {
const parentPath = options?.parentPath?.fsPath;
const result = await this.#cloneManager.clone(uri.toString(), { parentPath, recursive: options?.recursive, ref: options?.ref, postCloneAction: options?.postCloneAction, skipCache: options?.skipCache });
const result = await this.#cloneManager.clone(uri.toString(), { parentPath, recursive: options?.recursive, ref: options?.ref, postCloneAction: options?.postCloneAction });
return result ? Uri.file(result) : null;
}

8
extensions/git/src/api/git.d.ts vendored
View File

@@ -193,8 +193,7 @@ export interface CloneOptions {
/**
* If no postCloneAction is provided, then the users setting for git.openAfterClone is used.
*/
postCloneAction?: 'none' | 'open' | 'prompt';
skipCache?: boolean;
postCloneAction?: 'none';
}
export interface RefQuery {
@@ -379,9 +378,12 @@ export interface API {
toGitUri(uri: Uri, ref: string): Uri;
getRepository(uri: Uri): Repository | null;
getRepositoryRoot(uri: Uri): Promise<Uri | null>;
getRepositoryWorkspace(uri: Uri): Promise<Uri[] | null>;
init(root: Uri, options?: InitOptions): Promise<Repository | null>;
/**
* @returns The URI of either the cloned repository, or the workspace file or folder which contains the cloned repository.
* Checks the cache of known cloned repositories, and clones if the repository is not found.
* Make sure to pass `postCloneAction` 'none' if you want to have the uri where you can find the repository returned.
* @returns The URI of a folder or workspace file which, when opened, will open the cloned repository.
*/
clone(uri: Uri, options?: CloneOptions): Promise<Uri | null>;
openRepository(root: Uri): Promise<Repository | null>;