From 79c14564df64d607bc0adca9132a370c2f2c9997 Mon Sep 17 00:00:00 2001 From: Matt Bierner <12821956+mjbvz@users.noreply.github.com> Date: Mon, 9 Mar 2026 23:14:30 -0700 Subject: [PATCH] Reduce any usage in consoleForwarder For #269213 --- src/vs/workbench/api/common/extHostConsoleForwarder.ts | 10 +++++----- src/vs/workbench/api/node/extHostConsoleForwarder.ts | 5 ++--- src/vs/workbench/api/worker/extHostConsoleForwarder.ts | 5 ++--- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/src/vs/workbench/api/common/extHostConsoleForwarder.ts b/src/vs/workbench/api/common/extHostConsoleForwarder.ts index 02559149900..8bd7fc9a912 100644 --- a/src/vs/workbench/api/common/extHostConsoleForwarder.ts +++ b/src/vs/workbench/api/common/extHostConsoleForwarder.ts @@ -46,13 +46,13 @@ export abstract class AbstractExtHostConsoleForwarder { Object.defineProperty(console, method, { set: () => { }, - get: () => function () { - that._handleConsoleCall(method, severity, original, arguments); + get: () => (...args: unknown[]) => { + that._handleConsoleCall(method, severity, original, args); }, }); } - private _handleConsoleCall(method: 'log' | 'info' | 'warn' | 'error' | 'debug', severity: 'log' | 'warn' | 'error' | 'debug', original: (...args: any[]) => void, args: IArguments): void { + private _handleConsoleCall(method: 'log' | 'info' | 'warn' | 'error' | 'debug', severity: 'log' | 'warn' | 'error' | 'debug', original: (...args: unknown[]) => void, args: unknown[]): void { this._mainThreadConsole.$logExtensionHostMessage({ type: '__$console', severity, @@ -63,7 +63,7 @@ export abstract class AbstractExtHostConsoleForwarder { } } - protected abstract _nativeConsoleLogMessage(method: 'log' | 'info' | 'warn' | 'error' | 'debug', original: (...args: any[]) => void, args: IArguments): void; + protected abstract _nativeConsoleLogMessage(method: 'log' | 'info' | 'warn' | 'error' | 'debug', original: (...args: unknown[]) => void, args: unknown[]): void; } @@ -72,7 +72,7 @@ const MAX_LENGTH = 100000; /** * Prevent circular stringify and convert arguments to real array */ -function safeStringifyArgumentsToArray(args: IArguments, includeStack: boolean): string { +function safeStringifyArgumentsToArray(args: unknown[], includeStack: boolean): string { const argsArray = []; // Massage some arguments with special treatment diff --git a/src/vs/workbench/api/node/extHostConsoleForwarder.ts b/src/vs/workbench/api/node/extHostConsoleForwarder.ts index d1568f28642..69ce4029ca0 100644 --- a/src/vs/workbench/api/node/extHostConsoleForwarder.ts +++ b/src/vs/workbench/api/node/extHostConsoleForwarder.ts @@ -24,12 +24,11 @@ export class ExtHostConsoleForwarder extends AbstractExtHostConsoleForwarder { this._wrapStream('stdout', 'log'); } - protected override _nativeConsoleLogMessage(method: 'log' | 'info' | 'warn' | 'error' | 'debug', original: (...args: any[]) => void, args: IArguments) { + protected override _nativeConsoleLogMessage(method: 'log' | 'info' | 'warn' | 'error' | 'debug', original: (...args: unknown[]) => void, args: unknown[]): void { const stream = method === 'error' || method === 'warn' ? process.stderr : process.stdout; this._isMakingConsoleCall = true; stream.write(`\n${NativeLogMarkers.Start}\n`); - // eslint-disable-next-line local/code-no-any-casts - original.apply(console, args as any); + original.apply(console, args); stream.write(`\n${NativeLogMarkers.End}\n`); this._isMakingConsoleCall = false; } diff --git a/src/vs/workbench/api/worker/extHostConsoleForwarder.ts b/src/vs/workbench/api/worker/extHostConsoleForwarder.ts index 01814a7d969..26eec2f9ad3 100644 --- a/src/vs/workbench/api/worker/extHostConsoleForwarder.ts +++ b/src/vs/workbench/api/worker/extHostConsoleForwarder.ts @@ -16,8 +16,7 @@ export class ExtHostConsoleForwarder extends AbstractExtHostConsoleForwarder { super(extHostRpc, initData); } - protected override _nativeConsoleLogMessage(_method: unknown, original: (...args: any[]) => void, args: IArguments) { - // eslint-disable-next-line local/code-no-any-casts - original.apply(console, args as any); + protected override _nativeConsoleLogMessage(_method: unknown, original: (...args: unknown[]) => void, args: unknown[]) { + original.apply(console, args); } }