From eeeab304b9ac777b4a8dddf55f66ffebd9e4e7f2 Mon Sep 17 00:00:00 2001 From: Alex Dima Date: Tue, 22 Feb 2022 15:08:54 +0100 Subject: [PATCH] Temporarily disable that remote extensions can run in the local web worker extension host (#141322) --- .../services/extensions/browser/extensionService.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/vs/workbench/services/extensions/browser/extensionService.ts b/src/vs/workbench/services/extensions/browser/extensionService.ts index 316fcc1040d..3d2545d79d7 100644 --- a/src/vs/workbench/services/extensions/browser/extensionService.ts +++ b/src/vs/workbench/services/extensions/browser/extensionService.ts @@ -201,11 +201,8 @@ export class ExtensionService extends AbstractExtensionService implements IExten // takes care of duplicates and picks a running location for each extension this._runningLocation = this._runningLocationClassifier.determineRunningLocation(localExtensions, remoteExtensions); - // Remote extensions can run locally in the web worker, so mix everything up and split them again based on running location - // NOTE: An extension can appear twice in `allExtensions`, but it will be filtered out based on running location below: - const allExtensions = remoteExtensions.concat(localExtensions); - localExtensions = filterByRunningLocation(allExtensions, this._runningLocation, ExtensionRunningLocation.LocalWebWorker); - remoteExtensions = filterByRunningLocation(allExtensions, this._runningLocation, ExtensionRunningLocation.Remote); + localExtensions = filterByRunningLocation(localExtensions, this._runningLocation, ExtensionRunningLocation.LocalWebWorker); + remoteExtensions = filterByRunningLocation(remoteExtensions, this._runningLocation, ExtensionRunningLocation.Remote); const result = this._registry.deltaExtensions(remoteExtensions.concat(localExtensions), []); if (result.removedDueToLooping.length > 0) {