Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 16:49:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Inline parameters to execution task start and end

Browse Source
This commit is contained in:
Rob Lourens
2021-06-01 16:13:27 -07:00
parent 5c6ae4fc5a
commit ef28d1663d
3 changed files with 26 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/api/common/extHostNotebookKernels.ts
View File

@@ -447,7 +447,7 @@ class NotebookCellExecutionTask extends Disposable {
});
},
start(context?: vscode.NotebookCellExecuteStartContext): void {
start(startTime?: number): void {
if (that._state === NotebookCellExecutionTaskState.Resolved || that._state === NotebookCellExecutionTaskState.Started) {
throw new Error('Cannot call start again');
}
@@ -457,11 +457,11 @@ class NotebookCellExecutionTask extends Disposable {
that.mixinMetadata({
runState: NotebookCellExecutionState.Executing,
runStartTime: context?.startTime ?? null
runStartTime: startTime ?? null
});
},
end(result?: vscode.NotebookCellExecuteEndContext): void {
end(success: boolean | undefined, endTime?: number): void {
if (that._state === NotebookCellExecutionTaskState.Resolved) {
throw new Error('Cannot call resolve twice');
}
@@ -471,8 +471,8 @@ class NotebookCellExecutionTask extends Disposable {
that.mixinMetadata({
runState: null,
lastRunSuccess: result?.success ?? null,
runEndTime: result?.endTime ?? null,
lastRunSuccess: success ?? null,
runEndTime: endTime ?? null,
});
},