Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-03 15:01:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

💄 jumplist

Browse Source
This commit is contained in:
Benjamin Pasero
2017-03-08 07:29:47 +01:00
parent 2edc95ddd5
commit ef8fdc296f
2 changed files with 6 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/code/electron-main/main.ts
View File

@@ -259,6 +259,10 @@ function main(accessor: ServicesAccessor, mainIpcServer: Server, userEnv: platfo
// Install Menu
instantiationService2.createInstance(VSCodeMenu);
// Jump List
windowsMainService.updateWindowsJumpList();
windowsMainService.onRecentPathsChange(() => windowsMainService.updateWindowsJumpList());
// Start shared process here
sharedProcess.spawn();
});

24
src/vs/code/electron-main/windows.ts
View File

@@ -121,6 +121,7 @@ export interface IWindowsMainService {
removeFromRecentPathsList(path: string): void;
removeFromRecentPathsList(paths: string[]): void;
clearRecentPathsList(): void;
updateWindowsJumpList(): void;
quit(): void;
}
@@ -141,8 +142,6 @@ export class WindowsManager implements IWindowsMainService {
private windowsState: IWindowsState;
private lastClosedWindowState: IWindowState;
private firstWindowLoading: boolean;
private _onRecentPathsChange = new Emitter<void>();
onRecentPathsChange: CommonEvent<void> = this._onRecentPathsChange.event;
@@ -251,9 +250,6 @@ export class WindowsManager implements IWindowsMainService {
// Update our windows state before quitting and before closing windows
this.lifecycleService.onBeforeWindowClose(win => this.onBeforeWindowClose(win));
this.lifecycleService.onBeforeQuit(() => this.onBeforeQuit());
// Update jump list when recent paths change
this.onRecentPathsChange(() => this.updateWindowsJumpList());
}
// Note that onBeforeQuit() and onBeforeWindowClose() are fired in different order depending on the OS:
@@ -862,7 +858,6 @@ export class WindowsManager implements IWindowsMainService {
vscodeWindow.win.webContents.removeAllListeners('devtools-reload-page'); // remove built in listener so we can handle this on our own
vscodeWindow.win.webContents.on('devtools-reload-page', () => this.reload(vscodeWindow));
vscodeWindow.win.webContents.on('crashed', () => this.onWindowError(vscodeWindow, WindowError.CRASHED));
vscodeWindow.win.webContents.on('did-start-loading', () => this.onWindowStartLoading(vscodeWindow));
vscodeWindow.win.on('unresponsive', () => this.onWindowError(vscodeWindow, WindowError.UNRESPONSIVE));
vscodeWindow.win.on('closed', () => this.onWindowClosed(vscodeWindow));
@@ -1265,26 +1260,11 @@ export class WindowsManager implements IWindowsMainService {
return pathA === pathB;
}
private onWindowStartLoading(win: VSCodeWindow): void {
if (!this.firstWindowLoading) {
this.firstWindowLoading = true;
// Apply jump list when our first window is loading. We do this because
// setJumpList() seems to take quite a bit of time and would block window
// loading ( = startup performance) significantly otherwise
setTimeout(() => this.updateWindowsJumpList()); // unwind from onWindowStartLoading event
}
}
private updateWindowsJumpList(): void {
public updateWindowsJumpList(): void {
if (!platform.isWindows) {
return; // only on windows
}
if (!this.firstWindowLoading) {
return; // push this out until a window starts loading for perf reasons
}
const jumpList: Electron.JumpListCategory[] = [];
// Tasks