From ef93f6eb65fef8362e2a637bc5ddfb6008e2ce08 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Thu, 18 Jun 2020 05:53:38 -0700 Subject: [PATCH] Update --- src/vs/workbench/api/common/extHostTerminalService.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts index ca40794123b..aebd2ec7949 100644 --- a/src/vs/workbench/api/common/extHostTerminalService.ts +++ b/src/vs/workbench/api/common/extHostTerminalService.ts @@ -670,8 +670,9 @@ export abstract class BaseExtHostTerminalService implements IExtHostTerminalServ return; } cachedLink.provider.handleTerminalLink(cachedLink.link); - - // TODO: Handle when result is false + // TODO: Handle when result is false? Should this be return void instead and remove + // TerminalLink.target? It's a simple call to window.openUri for the extension otherwise + // and would simplify the API. } private _onProcessExit(id: number, exitCode: number | undefined): void {