From f04ba7cf100c1d0382a5815fee21f3fa0e55fd0b Mon Sep 17 00:00:00 2001 From: Martin Aeschlimann Date: Wed, 23 Nov 2022 22:17:22 +0100 Subject: [PATCH] Height of common input components is not consistent (#167098) Height of common input components is not consistent. Fixes #167078 --- src/vs/base/browser/ui/inputbox/inputBox.css | 4 ---- src/vs/base/browser/ui/inputbox/inputBox.ts | 10 +++++----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/vs/base/browser/ui/inputbox/inputBox.css b/src/vs/base/browser/ui/inputbox/inputBox.css index 55b552b724f..9d52e6e66da 100644 --- a/src/vs/base/browser/ui/inputbox/inputBox.css +++ b/src/vs/base/browser/ui/inputbox/inputBox.css @@ -14,10 +14,6 @@ font-size: inherit; } -.monaco-inputbox.idle { - border: 1px solid transparent; -} - .monaco-inputbox > .ibwrapper > .input, .monaco-inputbox > .ibwrapper > .mirror { diff --git a/src/vs/base/browser/ui/inputbox/inputBox.ts b/src/vs/base/browser/ui/inputbox/inputBox.ts index 1a9a1b43360..0f6febba93f 100644 --- a/src/vs/base/browser/ui/inputbox/inputBox.ts +++ b/src/vs/base/browser/ui/inputbox/inputBox.ts @@ -377,7 +377,7 @@ export class InputBox extends Widget { this.element.classList.add(this.classForType(message.type)); const styles = this.stylesForType(this.message.type); - this.element.style.border = styles.border ? `1px solid ${styles.border}` : ''; + this.element.style.borderColor = styles.border || 'transparent'; if (this.message.content && (this.hasFocus() || force)) { this._showMessage(); @@ -551,10 +551,10 @@ export class InputBox extends Widget { this.input.style.backgroundColor = 'inherit'; this.input.style.color = foreground; - if (border) { - this.element.style.border = '1px solid ' + border; - } - + // there's always a border, even if the color is not set. + this.element.style.borderColor = border || 'transparent'; + this.element.style.borderWidth = '1px'; + this.element.style.borderStyle = 'solid'; } public layout(): void {