From f436da65b35cedf04177a4e6f0879328c494bc9f Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Sun, 11 Feb 2018 13:20:44 -0800 Subject: [PATCH] Log settings search remote errors to log service --- .../workbench/parts/preferences/browser/preferencesEditor.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts index ab6c3aa9821..49d0798d3bf 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts @@ -61,6 +61,7 @@ import { IHashService } from 'vs/workbench/services/hash/common/hashService'; import { ConfigurationScope } from 'vs/platform/configuration/common/configurationRegistry'; import { IStringDictionary } from 'vs/base/common/collections'; import { IProgressService } from 'vs/platform/progress/common/progress'; +import { ILogService } from 'vs/platform/log/common/log'; export class PreferencesEditorInput extends SideBySideEditorInput { public static ID: string = 'workbench.editorinputs.preferencesEditorInput'; @@ -402,7 +403,8 @@ class PreferencesRenderersController extends Disposable { @IPreferencesSearchService private preferencesSearchService: IPreferencesSearchService, @ITelemetryService private telemetryService: ITelemetryService, @IPreferencesService private preferencesService: IPreferencesService, - @IWorkspaceContextService private workspaceContextService: IWorkspaceContextService + @IWorkspaceContextService private workspaceContextService: IWorkspaceContextService, + @ILogService private logService: ILogService ) { super(); } @@ -624,6 +626,7 @@ class PreferencesRenderersController extends Disposable { if (message && message !== 'Error') { // "Error" = any generic network error this.telemetryService.publicLog('defaultSettings.searchError', { message, filter }); + this.logService.info('Setting search error: ' + message); } return null; }