Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 10:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

destory notebook should clear both core and ext host.

Browse Source
This commit is contained in:
rebornix
2020-01-26 19:37:17 -08:00
parent ed12c87dfa
commit f4938e31fc
4 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/api/browser/mainThreadNotebook.ts
View File

@@ -274,6 +274,7 @@ export class MainThreadNotebookController implements IMainNotebookController {
}
async resolveNotebook(viewType: string, uri: URI): Promise<INotebook | undefined> {
// TODO: resolve notebook should wait for all notebook document destory operations to finish.
let mainthreadNotebook = this._mapping.get(URI.from(uri).toString());
if (mainthreadNotebook) {
@@ -367,12 +368,15 @@ export class MainThreadNotebookController implements IMainNotebookController {
}
}
destoryNotebookDocument(notebook: INotebook): void {
async destoryNotebookDocument(notebook: INotebook): Promise<void> {
let mainthreadNotebook = this._mapping.get(URI.from(notebook.uri).toString());
if (mainthreadNotebook) {
mainthreadNotebook.dispose();
this._mapping.delete(URI.from(notebook.uri).toString());
let removeFromExtHost = await this._proxy.$destoryNotebookDocument(this._viewType, notebook.uri);
if (removeFromExtHost) {
mainthreadNotebook.dispose();
this._mapping.delete(URI.from(notebook.uri).toString());
}
}
}
}