Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-22 01:29:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add test for completeFunctionCalls

Browse Source
This commit is contained in:
Matt Bierner
2019-01-08 16:07:40 -08:00
parent 6eeb11ecf2
commit f49c40947e
1 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
extensions/typescript-language-features/src/test/completions.test.ts
View File

@@ -12,22 +12,27 @@ const testDocumentUri = vscode.Uri.parse('untitled:test.ts');
type VsCodeConfiguration = { [key: string]: any };
async function updateConfig(newConfig: VsCodeConfiguration): Promise<VsCodeConfiguration> {
const oldConfig: VsCodeConfiguration = {};
const config = vscode.workspace.getConfiguration(undefined, testDocumentUri);
for (const configKey of Object.keys(newConfig)) {
oldConfig[configKey] = config.get(configKey);
await new Promise((resolve, reject) => config.update(configKey, newConfig[configKey], vscode.ConfigurationTarget.Global).then(() => resolve(), reject));
await new Promise((resolve, reject) =>
config.update(configKey, newConfig[configKey], vscode.ConfigurationTarget.Global)
.then(() => resolve(), reject));
}
return oldConfig;
}
namespace Config {
export const suggestSelection = 'editor.suggestSelection';
export const completeFunctionCalls = 'typescript.suggest.completeFunctionCalls';
}
suite('TypeScript Completions', () => {
const configDefaults: VsCodeConfiguration = Object.freeze({
'editor.suggestSelection': 'first',
'typescript.suggest.completeFunctionCalls': false,
[Config.suggestSelection]: 'first',
[Config.completeFunctionCalls]: false,
});
const _disposables: vscode.Disposable[] = [];
@@ -182,6 +187,25 @@ suite('TypeScript Completions', () => {
`abc`
));
});
test('completeFunctionCalls should complete function parameters', async () => {
await updateConfig({
[Config.completeFunctionCalls]: true,
});
await createTestEditor(testDocumentUri,
`function foo(x, y, z) { }`,
`foo$0`
);
const document = await acceptFirstSuggestion(testDocumentUri, _disposables);
assert.strictEqual(
document.getText(),
joinLines(
`function foo(x, y, z) { }`,
`foo(x, y, z)`
));
});
});
const joinLines = (...args: string[]) => args.join('\n');
@@ -193,6 +217,9 @@ async function acceptFirstSuggestion(uri: vscode.Uri, _disposables: vscode.Dispo
const didSuggest = onDidSuggest(_disposables);
await vscode.commands.executeCommand('editor.action.triggerSuggest');
await didSuggest;
// TODO: depends on reverting fix for https://github.com/Microsoft/vscode/issues/64257
// Make sure we have time to resolve the suggestion because `acceptSelectedSuggestion` doesn't
await wait(40);
await vscode.commands.executeCommand('acceptSelectedSuggestion');
return await didChangeDocument;
}