Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 00:28:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fire onDidHide only once (fixes #57852)

Browse Source
This commit is contained in:
Christof Marti
2018-10-04 13:10:03 +02:00
parent 120c98ca02
commit f523fd2036
2 changed files with 48 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
extensions/vscode-api-tests/src/singlefolder-tests/quickInput.test.ts
View File

@@ -160,6 +160,48 @@ suite('window namespace tests', function () {
})()
.catch(err => done(err));
});
test('createQuickPick, dispose in onDidHide', function (_done) {
let done = (err?: any) => {
done = () => {};
_done(err);
};
let hidden = false;
const quickPick = window.createQuickPick();
quickPick.onDidHide(() => {
if (hidden) {
done(new Error('Already hidden'));
} else {
hidden = true;
quickPick.dispose();
setTimeout(done, 0);
}
});
quickPick.show();
quickPick.hide();
});
test('createQuickPick, hide and dispose', function (_done) {
let done = (err?: any) => {
done = () => {};
_done(err);
};
let hidden = false;
const quickPick = window.createQuickPick();
quickPick.onDidHide(() => {
if (hidden) {
done(new Error('Already hidden'));
} else {
hidden = true;
setTimeout(done, 0);
}
});
quickPick.show();
quickPick.hide();
quickPick.dispose();
});
});
});