Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 08:38:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ignore 0,0 event to fix override dimensions pty test

Browse Source 
See #83778 for follow up (when we're not in endgame)
This commit is contained in:
Daniel Imms
2019-10-31 11:39:03 -07:00
parent 82c348326c
commit f5cb824330
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
View File

@@ -96,6 +96,7 @@ suite('window namespace tests', () => {
}));
const terminal = window.createTerminal('b');
});
// test('onDidChangeActiveTerminal should fire when new terminals are created', (done) => {
// const reg1 = window.onDidChangeActiveTerminal((active: Terminal | undefined) => {
// equal(active, terminal);
@@ -341,6 +342,10 @@ suite('window namespace tests', () => {
}
term.show();
disposables.push(window.onDidChangeTerminalDimensions(e => {
if (e.dimensions.columns === 0 || e.dimensions.rows === 0) {
// HACK: Ignore the event if dimension(s) are zero (#83778)
return;
}
try {
equal(e.dimensions.columns, 10);
equal(e.dimensions.rows, 5);