address pr comments

This commit is contained in:
Connor Peet
2023-05-11 12:29:42 -07:00
parent 364b84e3ec
commit f76fd4f664
8 changed files with 163 additions and 24 deletions

View File

@@ -71,19 +71,19 @@ export class ExtHostManagedSockets implements IExtHostManagedSockets {
}
$remoteSocketWrite(socketId: number, buffer: VSBuffer): void {
this._managedRemoteSockets.get(socketId)?.actual.dataHandler(buffer.buffer);
this._managedRemoteSockets.get(socketId)?.actual.send(buffer.buffer);
}
$remoteSocketEnd(socketId: number): void {
const socket = this._managedRemoteSockets.get(socketId);
if (socket) {
socket.actual.endHandler();
socket.actual.end();
socket.dispose();
}
}
$remoteSocketDrain(socketId: number): Promise<void> {
return this._managedRemoteSockets.get(socketId)?.actual.drainHandler?.() ?? Promise.resolve();
async $remoteSocketDrain(socketId: number): Promise<void> {
await this._managedRemoteSockets.get(socketId)?.actual.drain?.();
}
}