From f7784f32afe5356d624d0cc324642bc6fa7b2c93 Mon Sep 17 00:00:00 2001 From: mrleemurray Date: Thu, 26 Mar 2026 15:30:40 +0000 Subject: [PATCH] refactor: update CIStatusWidget dimensions and adjust layout in ChangesViewPane Co-authored-by: Copilot --- .../sessions/contrib/changes/browser/changesView.ts | 13 ++++++------- .../contrib/changes/browser/ciStatusWidget.ts | 3 ++- .../changes/browser/media/ciStatusWidget.css | 7 ++++--- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/vs/sessions/contrib/changes/browser/changesView.ts b/src/vs/sessions/contrib/changes/browser/changesView.ts index abf43f478b6..f8282da0f9e 100644 --- a/src/vs/sessions/contrib/changes/browser/changesView.ts +++ b/src/vs/sessions/contrib/changes/browser/changesView.ts @@ -440,13 +440,13 @@ export class ChangesViewPane extends ViewPane { })); // Shared constants for pane sizing - const ciMarginTop = 8; // matches margin-top on .ci-status-widget - const ciMinHeight = CIStatusWidget.HEADER_HEIGHT + CIStatusWidget.MIN_BODY_HEIGHT + ciMarginTop; + const ciMinHeight = CIStatusWidget.HEADER_HEIGHT + CIStatusWidget.MIN_BODY_HEIGHT; + const treeMinHeight = 3 * 22; // three tree rows (row height = 22) // Top pane: file tree const treePane: IView = { element: this.contentContainer, - minimumSize: ciMinHeight, + minimumSize: treeMinHeight, maximumSize: Number.POSITIVE_INFINITY, onDidChange: Event.None, layout: (height) => { @@ -464,15 +464,14 @@ export class ChangesViewPane extends ViewPane { maximumSize: Number.POSITIVE_INFINITY, onDidChange: Event.map(this.ciStatusWidget.onDidChangeHeight, () => undefined), layout: (height) => { - const innerHeight = Math.max(0, height - ciMarginTop); - ciElement.style.height = `${innerHeight}px`; - const bodyHeight = Math.max(0, innerHeight - CIStatusWidget.HEADER_HEIGHT); + ciElement.style.height = `${height}px`; + const bodyHeight = Math.max(0, height - CIStatusWidget.HEADER_HEIGHT); ciWidget.layout(bodyHeight); }, }; this.splitView.addView(treePane, Sizing.Distribute, 0, true); - this.splitView.addView(ciPane, CIStatusWidget.HEADER_HEIGHT + CIStatusWidget.MIN_BODY_HEIGHT + ciMarginTop, 1, true); + this.splitView.addView(ciPane, CIStatusWidget.HEADER_HEIGHT + CIStatusWidget.PREFERRED_BODY_HEIGHT, 1, true); // Style the sash as a visible separator between sections const updateSplitViewStyles = () => { diff --git a/src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts b/src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts index c1ca007b580..63dab1fb216 100644 --- a/src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts +++ b/src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts @@ -136,7 +136,8 @@ class CICheckListRenderer implements IListRenderer