diff --git a/src/vs/workbench/api/common/extHostTypes.ts b/src/vs/workbench/api/common/extHostTypes.ts index 2b6b40d9b60..d36356e7b79 100644 --- a/src/vs/workbench/api/common/extHostTypes.ts +++ b/src/vs/workbench/api/common/extHostTypes.ts @@ -1736,8 +1736,8 @@ export class TerminalLink implements vscode.TerminalLink { } export enum TerminalLocation { - Panel = 0, - Editor = 1, + Panel = 1, + Editor = 2, } export class TerminalProfile implements vscode.TerminalProfile { diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts index 807a6df14a5..f772199a6df 100644 --- a/src/vs/workbench/api/node/extHostTerminalService.ts +++ b/src/vs/workbench/api/node/extHostTerminalService.ts @@ -6,7 +6,6 @@ import { generateUuid } from 'vs/base/common/uuid'; import { IExtHostRpcService } from 'vs/workbench/api/common/extHostRpcService'; import { BaseExtHostTerminalService, ExtHostTerminal, ITerminalInternalOptions } from 'vs/workbench/api/common/extHostTerminalService'; -import { TerminalLocation } from 'vs/workbench/api/common/extHostTypes'; import type * as vscode from 'vscode'; export class ExtHostTerminalService extends BaseExtHostTerminalService { @@ -38,7 +37,7 @@ export class ExtHostTerminalService extends BaseExtHostTerminalService { internalOptions.resolvedExtHostIdentifier = parentExtHostTerminal._id; } } - } else if (options.location === TerminalLocation.Editor || options.location === TerminalLocation.Panel) { + } else if (options.location && typeof options.location !== 'object') { internalOptions.location = options.location; } else if (internalOptions.location && typeof internalOptions.location === 'object' && 'splitActiveTerminal' in internalOptions.location) { internalOptions.location = { splitActiveTerminal: true };