Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 19:44:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #145090 from microsoft/rebornix/notebook-commenting

Browse Source 
notebook comment support
This commit is contained in:
Peng Lyu
2022-03-17 12:58:59 -07:00
committed by GitHub
parent b6f6a37cbd 14635e26ce
commit f890d96e35
23 changed files with 1730 additions and 1047 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/api/common/extHost.protocol.ts
View File

@@ -114,8 +114,8 @@ export interface CommentChanges {
readonly timestamp?: string;
}
export type CommentThreadChanges = Partial<{
range: IRange;
export type CommentThreadChanges<T = IRange> = Partial<{
range: T;
label: string;
contextValue: string | null;
comments: CommentChanges[];
@@ -128,11 +128,11 @@ export interface MainThreadCommentsShape extends IDisposable {
$registerCommentController(handle: number, id: string, label: string): void;
$unregisterCommentController(handle: number): void;
$updateCommentControllerFeatures(handle: number, features: CommentProviderFeatures): void;
$createCommentThread(handle: number, commentThreadHandle: number, threadId: string, resource: UriComponents, range: IRange, extensionId: ExtensionIdentifier): languages.CommentThread | undefined;
$createCommentThread(handle: number, commentThreadHandle: number, threadId: string, resource: UriComponents, range: IRange | ICellRange, extensionId: ExtensionIdentifier): languages.CommentThread<IRange | ICellRange> | undefined;
$updateCommentThread(handle: number, commentThreadHandle: number, threadId: string, resource: UriComponents, changes: CommentThreadChanges): void;
$deleteCommentThread(handle: number, commentThreadHandle: number): void;
$updateCommentingRanges(handle: number): void;
$onDidCommentThreadsChange(handle: number, event: languages.CommentThreadChangedEvent): void;
$onDidCommentThreadsChange(handle: number, event: languages.CommentThreadChangedEvent<IRange | ICellRange>): void;
}
export interface MainThreadAuthenticationShape extends IDisposable {