diff --git a/src/vs/workbench/api/common/extHost.api.impl.ts b/src/vs/workbench/api/common/extHost.api.impl.ts index 5a1465f00a3..acdf0672025 100644 --- a/src/vs/workbench/api/common/extHost.api.impl.ts +++ b/src/vs/workbench/api/common/extHost.api.impl.ts @@ -673,7 +673,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I checkProposedApiEnabled(extension, 'editorInsets'); return extHostEditorInsets.createWebviewEditorInset(editor, line, height, options, extension); }, - createTerminal(nameOrOptions?: vscode.TerminalOptions | vscode.ExtensionTerminalOptions | string, shellPath?: string, shellArgs?: string[] | string): vscode.Terminal { + createTerminal(nameOrOptions?: vscode.TerminalOptions | vscode.ExtensionTerminalOptions | string, shellPath?: string, shellArgs?: readonly string[] | string): vscode.Terminal { if (typeof nameOrOptions === 'object') { if ('pty' in nameOrOptions) { return extHostTerminalService.createExtensionTerminal(nameOrOptions); diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts index 12643cef941..1aa1e678e00 100644 --- a/src/vs/workbench/api/common/extHostTerminalService.ts +++ b/src/vs/workbench/api/common/extHostTerminalService.ts @@ -38,7 +38,7 @@ export interface IExtHostTerminalService extends ExtHostTerminalServiceShape, ID onDidChangeTerminalState: Event; onDidWriteTerminalData: Event; - createTerminal(name?: string, shellPath?: string, shellArgs?: string[] | string): vscode.Terminal; + createTerminal(name?: string, shellPath?: string, shellArgs?: readonly string[] | string): vscode.Terminal; createTerminalFromOptions(options: vscode.TerminalOptions, internalOptions?: ITerminalInternalOptions): vscode.Terminal; createExtensionTerminal(options: vscode.ExtensionTerminalOptions): vscode.Terminal; attachPtyToTerminal(id: number, pty: vscode.Pseudoterminal): void; diff --git a/src/vscode-dts/vscode.d.ts b/src/vscode-dts/vscode.d.ts index badebabb873..d99d78c8c89 100644 --- a/src/vscode-dts/vscode.d.ts +++ b/src/vscode-dts/vscode.d.ts @@ -3530,7 +3530,7 @@ declare module 'vscode' { * value starting at 1. * @return This snippet string. */ - appendChoice(values: string[], number?: number): SnippetString; + appendChoice(values: readonly string[], number?: number): SnippetString; /** * Builder-function that appends a variable (`${VAR}`) to @@ -3622,7 +3622,7 @@ declare module 'vscode' { * @param tokenType The token type. * @param tokenModifiers The token modifiers. */ - push(range: Range, tokenType: string, tokenModifiers?: string[]): void; + push(range: Range, tokenType: string, tokenModifiers?: readonly string[]): void; /** * Finish and create a `SemanticTokens` instance. @@ -9522,7 +9522,7 @@ declare module 'vscode' { * @return A new Terminal. * @throws When running in an environment where a new process cannot be started. */ - export function createTerminal(name?: string, shellPath?: string, shellArgs?: string[] | string): Terminal; + export function createTerminal(name?: string, shellPath?: string, shellArgs?: readonly string[] | string): Terminal; /** * Creates a {@link Terminal} with a backing shell process. @@ -11000,7 +11000,7 @@ declare module 'vscode' { * * @param thenable A thenable that resolves to {@link TextEdit pre-save-edits}. */ - waitUntil(thenable: Thenable): void; + waitUntil(thenable: Thenable): void; /** * Allows to pause the event loop until the provided thenable resolved.