From f8c833a89bfaf197a82863c7f080c720f558c39d Mon Sep 17 00:00:00 2001 From: Dirk Baeumer Date: Mon, 7 Jan 2019 10:54:48 +0100 Subject: [PATCH] Fix undefined checks --- src/vs/workbench/parts/tasks/common/problemMatcher.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/parts/tasks/common/problemMatcher.ts b/src/vs/workbench/parts/tasks/common/problemMatcher.ts index 99d62de8d43..d8e59d0cbee 100644 --- a/src/vs/workbench/parts/tasks/common/problemMatcher.ts +++ b/src/vs/workbench/parts/tasks/common/problemMatcher.ts @@ -347,10 +347,10 @@ abstract class AbstractLineMatcher implements ILineMatcher { } private createLocation(startLine: number, startColumn: number | undefined, endLine: number | undefined, endColumn: number | undefined): Location { - if (startLine && startColumn && endColumn) { + if (startColumn !== undefined && endColumn !== undefined) { return { startLineNumber: startLine, startCharacter: startColumn, endLineNumber: endLine || startLine, endCharacter: endColumn }; } - if (startLine && startColumn) { + if (startColumn !== undefined) { return { startLineNumber: startLine, startCharacter: startColumn, endLineNumber: startLine, endCharacter: startColumn }; } return { startLineNumber: startLine, startCharacter: 1, endLineNumber: startLine, endCharacter: Number.MAX_VALUE };