From f8cf8f39be4dbf7bcab2a22181ab571ee40d2b6d Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Mon, 5 Jul 2021 10:47:24 +0200 Subject: [PATCH] toDisposable should be once'd, fyi @hediet, @alexdima --- src/vs/base/common/lifecycle.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/base/common/lifecycle.ts b/src/vs/base/common/lifecycle.ts index f3168ad6e0e..0285e310644 100644 --- a/src/vs/base/common/lifecycle.ts +++ b/src/vs/base/common/lifecycle.ts @@ -122,10 +122,10 @@ export function combinedDisposable(...disposables: IDisposable[]): IDisposable { export function toDisposable(fn: () => void): IDisposable { const self = trackDisposable({ - dispose: () => { + dispose: once(() => { markTracked(self); fn(); - } + }) }); return self; }