Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 17:19:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

cli: fix renamed self-update name, cleanup old binaries

Browse Source 
Fixes #192948
This commit is contained in:
Connor Peet
2023-09-21 11:56:43 -07:00
parent 4fa7137b05
commit f92db2f96e
3 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
cli/src/self_update.rs
View File

@@ -24,6 +24,8 @@ pub struct SelfUpdate<'a> {
update_service: &'a UpdateService,
}
static OLD_UPDATE_EXTENSION: &str = "Updating CLI";
impl<'a> SelfUpdate<'a> {
pub fn new(update_service: &'a UpdateService) -> Result<Self, AnyError> {
let commit = VSCODE_CLI_COMMIT
@@ -59,6 +61,18 @@ impl<'a> SelfUpdate<'a> {
release.commit == self.commit
}
/// Cleans up old self-updated binaries. Should be called with regularity.
/// May fail if old versions are still running.
pub fn cleanup_old_update(&self) -> Result<(), std::io::Error> {
let current_path = std::env::current_exe()?;
let old_path = current_path.with_extension(OLD_UPDATE_EXTENSION);
if old_path.exists() {
fs::remove_file(old_path)?;
}
Ok(())
}
/// Updates the CLI to the given release.
pub async fn do_update(
&self,
@@ -89,8 +103,11 @@ impl<'a> SelfUpdate<'a> {
// OS later. However, this can fail if the tempdir is on a different drive
// than the installation dir. In this case just rename it to ".old".
if fs::rename(&target_path, tempdir.path().join("old-code-cli")).is_err() {
fs::rename(&target_path, target_path.with_extension(".old"))
.map_err(|e| wrap(e, "failed to rename old CLI"))?;
fs::rename(
&target_path,
target_path.with_extension(OLD_UPDATE_EXTENSION),
)
.map_err(|e| wrap(e, "failed to rename old CLI"))?;
}
fs::rename(&staging_path, &target_path)