Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-22 09:38:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

💄 notebook cell decoration type

Browse Source
This commit is contained in:
Peng Lyu
2025-03-19 17:43:18 -07:00
parent 59e5c3e4cf
commit f9565f0e11
3 changed files with 53 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/vs/workbench/contrib/notebook/browser/viewModel/notebookViewModelImpl.ts
View File

@@ -23,7 +23,7 @@ import { FoldingRegions } from '../../../../../editor/contrib/folding/browser/fo
import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
import { IUndoRedoService } from '../../../../../platform/undoRedo/common/undoRedo.js';
import { CellFindMatchModel } from '../contrib/find/findModel.js';
import { CellEditState, CellFindMatchWithIndex, CellFoldingState, EditorFoldingStateDelegate, ICellModelDecorations, ICellModelDeltaDecorations, ICellViewModel, IModelDecorationsChangeAccessor, INotebookDeltaCellStatusBarItems, INotebookDeltaDecoration, INotebookEditorViewState, INotebookViewCellsUpdateEvent, INotebookViewModel } from '../notebookBrowser.js';
import { CellEditState, CellFindMatchWithIndex, CellFoldingState, EditorFoldingStateDelegate, ICellModelDecorations, ICellModelDeltaDecorations, ICellViewModel, IModelDecorationsChangeAccessor, INotebookDeltaCellStatusBarItems, INotebookEditorViewState, INotebookViewCellsUpdateEvent, INotebookViewModel, INotebookDeltaDecoration, isNotebookCellDecoration } from '../notebookBrowser.js';
import { NotebookLayoutInfo, NotebookMetadataChangedEvent } from '../notebookViewEvents.js';
import { NotebookCellSelectionCollection } from './cellSelectionCollection.js';
import { CodeCellViewModel } from './codeCellViewModel.js';
@@ -723,18 +723,24 @@ export class NotebookViewModel extends Disposable implements EditorFoldingStateD
cell?.deltaCellDecorations([id], []);
this._decorationIdToCellMap.delete(id);
}
// TODO@rebornix: trigger view zone decorations removal
});
const result: string[] = [];
newDecorations.forEach(decoration => {
const cell = this.getCellByHandle(decoration.handle);
const ret = cell?.deltaCellDecorations([], [decoration.options]) || [];
ret.forEach(id => {
this._decorationIdToCellMap.set(id, decoration.handle);
});
if (isNotebookCellDecoration(decoration)) {
const cell = this.getCellByHandle(decoration.handle);
const ret = cell?.deltaCellDecorations([], [decoration.options]) || [];
ret.forEach(id => {
this._decorationIdToCellMap.set(id, decoration.handle);
});
result.push(...ret);
} else {
// TODO@rebornix trigger view zone decorations
}
result.push(...ret);
});
return result;