Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 02:58:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Expose shell's environment - fish shell (#240971)

Browse Source 
* start working on fish, save progress, still lots TODO

* modify proposed.terminalShellEnv.d.ts

* remember we dont have acccess to nonce in .fish script

* save progress, adding isTrusted

* two arrays approach in fish

* provide EnvClear for fish, other shell as well.

* fix tests

* REMOVE TWO ARRAYS METHOD, always send all env

* remove deprecated comments

* remove junk get ready for review

* dont import vscode in terminal/common/capabilities.ts

* take feedback => pass in Clear as part of EnvSingleStart

* add env clear argument to SI.zsh

* update one more place to prevent vscode import

* mandatory flag description?? discuss this

* make things right
Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>

* comment out test code

* use mapsStrictEqualIgnoreOrder instead of equals

* ready to go
This commit is contained in:
Anthony Kim
2025-02-20 10:42:48 -08:00
committed by GitHub
parent 0adf97d3d6
commit f99c5c64bc
13 changed files with 167 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/vscode-api-tests/src/singlefolder-tests/terminal.shellIntegration.test.ts
View File

@@ -99,8 +99,9 @@ import { assertNoRpc } from '../utils';
}));
});
ok(shellIntegration.env);
ok(shellIntegration.env.PATH);
ok(shellIntegration.env.PATH.length > 0, 'env.PATH should have a length greater than 0');
ok(shellIntegration.env.value);
ok(shellIntegration.env.value.PATH);
ok(shellIntegration.env.value.PATH.length > 0, 'env.value.PATH should have a length greater than 0');
});
}