Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

make INotebookKernel2 extends INotebookKernel

Browse Source
This commit is contained in:
Johannes Rieken
2021-04-19 11:56:18 +02:00
parent 6b9bd78998
commit f9fec24b45
6 changed files with 25 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/vs/workbench/api/browser/mainThreadNotebookKernels.ts
View File

@@ -89,8 +89,13 @@ abstract class MainThreadKernel implements INotebookKernel2 {
this._onDidChange.fire(event);
}
abstract executeNotebookCellsRequest(uri: URI, ranges: ICellRange[]): void;
abstract cancelNotebookCellExecution(uri: URI, ranges: ICellRange[]): void;
abstract executeNotebookCellsRequest(uri: URI, ranges: ICellRange[]): Promise<void>;
abstract cancelNotebookCellExecution(uri: URI, ranges: ICellRange[]): Promise<void>;
// old stuff
readonly resolve = () => Promise.resolve();
get friendlyId() { return this.id; }
get providerHandle() { return undefined; }
}
@extHostNamedCustomer(MainContext.MainThreadNotebookKernels)
@@ -185,11 +190,11 @@ export class MainThreadNotebookKernels implements MainThreadNotebookKernelsShape
async $addKernel(handle: number, data: INotebookKernelDto2): Promise<void> {
const that = this;
const kernel = new class extends MainThreadKernel {
executeNotebookCellsRequest(uri: URI, ranges: ICellRange[]): void {
that._proxy.$executeCells(handle, uri, ranges);
async executeNotebookCellsRequest(uri: URI, ranges: ICellRange[]): Promise<void> {
await that._proxy.$executeCells(handle, uri, ranges);
}
cancelNotebookCellExecution(uri: URI, ranges: ICellRange[]): void {
that._proxy.$cancelCells(handle, uri, ranges);
async cancelNotebookCellExecution(uri: URI, ranges: ICellRange[]): Promise<void> {
await that._proxy.$cancelCells(handle, uri, ranges);
}
}(data);
const registration = this._notebookKernelService.registerKernel(kernel);