diff --git a/extensions/emmet/src/abbreviationActions.ts b/extensions/emmet/src/abbreviationActions.ts
index da56664ca2e..765834a9292 100644
--- a/extensions/emmet/src/abbreviationActions.ts
+++ b/extensions/emmet/src/abbreviationActions.ts
@@ -474,6 +474,10 @@ export function isValidLocationForEmmetAbbreviation(document: vscode.TextDocumen
let valid = true;
let foundSpace = false; // If < is found before finding whitespace, then its valid abbreviation. Eg:
= 0) {
const char = textToBackTrack[i];
i--;
diff --git a/extensions/emmet/src/defaultCompletionProvider.ts b/extensions/emmet/src/defaultCompletionProvider.ts
index 6c33f781282..0daed26f446 100644
--- a/extensions/emmet/src/defaultCompletionProvider.ts
+++ b/extensions/emmet/src/defaultCompletionProvider.ts
@@ -4,11 +4,9 @@
*--------------------------------------------------------------------------------------------*/
import * as vscode from 'vscode';
-import { HtmlNode, Node } from 'EmmetNode';
+import { Node } from 'EmmetNode';
import { isValidLocationForEmmetAbbreviation } from './abbreviationActions';
-import { getEmmetHelper, getNode, getInnerRange, getMappingForIncludedLanguages, parseDocument, getEmmetConfiguration, getEmmetMode, isStyleSheet } from './util';
-
-const allowedMimeTypesInScriptTag = ['text/html', 'text/plain', 'text/x-template', 'text/template'];
+import { getEmmetHelper, getNode, getMappingForIncludedLanguages, parseDocument, getEmmetConfiguration, getEmmetMode, isStyleSheet } from './util';
export class DefaultCompletionItemProvider implements vscode.CompletionItemProvider {
@@ -35,7 +33,7 @@ export class DefaultCompletionItemProvider implements vscode.CompletionItemProvi
return;
}
- let validateLocation = isSyntaxMapped && syntax === 'html';
+ let validateLocation = syntax === 'html';
let currentNode: Node | null = null;
// If document can be css parsed, get currentNode
diff --git a/extensions/emmet/src/test/abbreviationAction.test.ts b/extensions/emmet/src/test/abbreviationAction.test.ts
index 302fd6f8ce4..4f914717061 100644
--- a/extensions/emmet/src/test/abbreviationAction.test.ts
+++ b/extensions/emmet/src/test/abbreviationAction.test.ts
@@ -227,32 +227,32 @@ suite('Tests for Expand Abbreviations (HTML)', () => {
});
});
- test('Expand css when inside style tag in completion list (HTML)', () => {
- const abbreviation = 'm10';
- const expandedText = 'margin: 10px;';
+ // test('Expand css when inside style tag in completion list (HTML)', () => {
+ // const abbreviation = 'm10';
+ // const expandedText = 'margin: 10px;';
- return withRandomFileEditor(htmlContents, 'html', (editor, doc) => {
- editor.selection = new Selection(13, 3, 13, 6);
- const cancelSrc = new CancellationTokenSource();
- const completionPromise = completionProvider.provideCompletionItems(editor.document, editor.selection.active, cancelSrc.token);
- if (!completionPromise) {
- assert.equal(1, 2, `Problem with expanding m10`);
- return Promise.resolve();
- }
+ // return withRandomFileEditor(htmlContents, 'html', (editor, doc) => {
+ // editor.selection = new Selection(13, 3, 13, 6);
+ // const cancelSrc = new CancellationTokenSource();
+ // const completionPromise = completionProvider.provideCompletionItems(editor.document, editor.selection.active, cancelSrc.token);
+ // if (!completionPromise) {
+ // assert.equal(1, 2, `Problem with expanding m10`);
+ // return Promise.resolve();
+ // }
- return completionPromise.then((completionList: CompletionList) => {
- if (!completionList.items || !completionList.items.length) {
- assert.equal(1, 2, `Problem with expanding m10`);
- return Promise.resolve();
- }
- const emmetCompletionItem = completionList.items[0];
- assert.equal(emmetCompletionItem.label, expandedText, `Label of completion item doesnt match.`);
- assert.equal((emmetCompletionItem.documentation || '').replace(/\|/g, ''), expandedText, `Docs of completion item doesnt match.`);
- assert.equal(emmetCompletionItem.filterText, abbreviation, `FilterText of completion item doesnt match.`);
- return Promise.resolve();
- });
- });
- });
+ // return completionPromise.then((completionList: CompletionList) => {
+ // if (!completionList.items || !completionList.items.length) {
+ // assert.equal(1, 2, `Problem with expanding m10`);
+ // return Promise.resolve();
+ // }
+ // const emmetCompletionItem = completionList.items[0];
+ // assert.equal(emmetCompletionItem.label, expandedText, `Label of completion item doesnt match.`);
+ // assert.equal((emmetCompletionItem.documentation || '').replace(/\|/g, ''), expandedText, `Docs of completion item doesnt match.`);
+ // assert.equal(emmetCompletionItem.filterText, abbreviation, `FilterText of completion item doesnt match.`);
+ // return Promise.resolve();
+ // });
+ // });
+ // });
test('No expanding when html is excluded in the settings', () => {
return workspace.getConfiguration('emmet').update('excludeLanguages', ['html']).then(() => {