Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-04 15:25:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

extracting the method _increaseDiagnosticCodeCount to avoid duplication

Browse Source
This commit is contained in:
Aiday Marlen Kyzy
2023-08-21 17:01:53 +02:00
parent 8db8d30dfa
commit fb4b533d93
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts
+8 -5
View File
@@ -177,6 +177,13 @@ class DiagnosticsTelemetryManager extends Disposable {
this._timeout = setTimeout(() => { uris.forEach((uri) => this._updateDiagnosticCodes(uri)); }, 5000);
}
private _increaseDiagnosticCodeCount(code: string | number | undefined) {
if (code === undefined) {
return;
}
this._diagnosticCodesMap.set(Number(code), (this._diagnosticCodesMap.get(Number(code)) || 0) + 1);
}
private _updateDiagnosticCodes(uri: vscode.Uri) {
const uriString = uri.toString();
const previousDiagnostics = this._diagnosticSnapshotsMap.get(uriString);
@@ -185,11 +192,7 @@ class DiagnosticsTelemetryManager extends Disposable {
const diagnosticsDiff = currentDiagnostics.filter((diagnostic) => !previousDiagnostics?.some((previousDiagnostic) => equals(diagnostic, previousDiagnostic)));
diagnosticsDiff.forEach((diagnostic) => {
const code = diagnostic.code;
if (typeof code === 'string' || typeof code === 'number') {
this._diagnosticCodesMap.set(Number(code), (this._diagnosticCodesMap.get(Number(code)) || 0) + 1);
} else if (code !== undefined) {
this._diagnosticCodesMap.set(Number(code.value), (this._diagnosticCodesMap.get(Number(code.value)) || 0) + 1);
}
this._increaseDiagnosticCodeCount(typeof code === 'string' || typeof code === 'number' ? code : code?.value);
});
}