From fc06daea523cf6cb2679138d9fc6e3bcd560655e Mon Sep 17 00:00:00 2001 From: Matt Bierner <12821956+mjbvz@users.noreply.github.com> Date: Fri, 27 Mar 2026 09:53:03 -0700 Subject: [PATCH] Delete pointless test This test is 30 lines to test that a readonly constant is set --- .../localAgentSessionsController.test.ts | 32 +------------------ 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/src/vs/workbench/contrib/chat/test/browser/agentSessions/localAgentSessionsController.test.ts b/src/vs/workbench/contrib/chat/test/browser/agentSessions/localAgentSessionsController.test.ts index 46a9bd459a9..61115395402 100644 --- a/src/vs/workbench/contrib/chat/test/browser/agentSessions/localAgentSessionsController.test.ts +++ b/src/vs/workbench/contrib/chat/test/browser/agentSessions/localAgentSessionsController.test.ts @@ -5,12 +5,12 @@ import assert from 'assert'; import { CancellationToken } from '../../../../../../base/common/cancellation.js'; -import { Codicon } from '../../../../../../base/common/codicons.js'; import { Emitter, Event } from '../../../../../../base/common/event.js'; import { DisposableStore } from '../../../../../../base/common/lifecycle.js'; import { observableValue } from '../../../../../../base/common/observable.js'; import { URI } from '../../../../../../base/common/uri.js'; import { runWithFakedTimers } from '../../../../../../base/test/common/timeTravelScheduler.js'; +import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../../../base/test/common/utils.js'; import { TestInstantiationService } from '../../../../../../platform/instantiation/test/common/instantiationServiceMock.js'; import { workbenchInstantiationService } from '../../../../../test/browser/workbenchTestServices.js'; import { LocalAgentsSessionsController } from '../../../browser/agentSessions/localAgentSessionsController.js'; @@ -22,7 +22,6 @@ import { IChatChangedRequestEvent, IChatChangeEvent, IChatModel, IChatRequestMod import { LocalChatSessionUri } from '../../../common/model/chatUri.js'; import { MockChatService } from '../../common/chatService/mockChatService.js'; import { MockChatSessionsService } from '../../common/mockChatSessionsService.js'; -import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../../../base/test/common/utils.js'; function createTestTiming(options?: { created?: number; @@ -567,35 +566,6 @@ suite('LocalAgentsSessionsController', () => { }); }); - suite('Session Icon', () => { - test('should use Codicon.chatSparkle as icon', async () => { - return runWithFakedTimers({}, async () => { - const controller = createController(); - - const sessionResource = LocalChatSessionUri.forSession('icon-session'); - const mockModel = createMockChatModel({ - sessionResource, - hasRequests: true - }); - - mockChatService.addSession(mockModel); - mockChatService.setLiveSessionItems([{ - sessionResource, - title: 'Icon Session', - lastMessageDate: Date.now(), - isActive: true, - lastResponseState: ResponseModelState.Complete, - timing: createTestTiming() - }]); - - await controller.refresh(CancellationToken.None); - const sessions = controller.items; - assert.strictEqual(sessions.length, 1); - assert.strictEqual(sessions[0].iconPath, Codicon.chatSparkle); - }); - }); - }); - suite('Events', () => { test('should fire onDidChangeChatSessionItems when model progress changes', async () => { return runWithFakedTimers({}, async () => {