From fc8762e773c35d4e52e8a7375704af2e24698e5d Mon Sep 17 00:00:00 2001 From: Justin Chen <54879025+justschen@users.noreply.github.com> Date: Wed, 29 May 2024 04:55:02 +0000 Subject: [PATCH] defaults web issue report false and disable in Firefox (#213752) * turn off in release and in ff * update --- src/vs/workbench/contrib/issue/browser/issue.contribution.ts | 2 +- src/vs/workbench/contrib/issue/browser/issueService.ts | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/contrib/issue/browser/issue.contribution.ts b/src/vs/workbench/contrib/issue/browser/issue.contribution.ts index 601380c33e2..475437b79a9 100644 --- a/src/vs/workbench/contrib/issue/browser/issue.contribution.ts +++ b/src/vs/workbench/contrib/issue/browser/issue.contribution.ts @@ -40,7 +40,7 @@ Registry.as(ConfigurationExtensions.Configuration) properties: { 'issueReporter.experimental.webReporter': { type: 'boolean', - default: true, + default: false, description: 'Enable experimental issue reporter for web.', }, } diff --git a/src/vs/workbench/contrib/issue/browser/issueService.ts b/src/vs/workbench/contrib/issue/browser/issueService.ts index b67e59d7cbb..82f3ac2eb00 100644 --- a/src/vs/workbench/contrib/issue/browser/issueService.ts +++ b/src/vs/workbench/contrib/issue/browser/issueService.ts @@ -4,7 +4,7 @@ *--------------------------------------------------------------------------------------------*/ import * as dom from 'vs/base/browser/dom'; -import { userAgent } from 'vs/base/common/platform'; +import { isFirefox, userAgent } from 'vs/base/common/platform'; import { IExtensionDescription, ExtensionType } from 'vs/platform/extensions/common/extensions'; import { normalizeGitHubUrl } from 'vs/platform/issue/common/issueReporterUtil'; import { getZoomLevel } from 'vs/base/browser/browser'; @@ -49,7 +49,8 @@ export class BrowserIssueService implements IWorkbenchIssueService { } async openReporter(options: Partial): Promise { - if (!this.configurationService.getValue('issueReporter.experimental.webReporter')) { + // If web reporter setting is false, or if we are in Firefox, open the old GitHub issue reporter + if (!this.configurationService.getValue('issueReporter.experimental.webReporter') || isFirefox) { const extensionId = options.extensionId; // If we don't have a extensionId, treat this as a Core issue if (!extensionId) {