Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 00:59:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix compile errors, evolve internal API about kernel selection

Browse Source
This commit is contained in:
Johannes Rieken
2021-04-13 14:29:46 +02:00
parent 1aa4efcd7a
commit fcd005ce8c
8 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/vs/workbench/api/common/extHostNotebookKernels.ts
View File

@@ -21,7 +21,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
private readonly _proxy: MainThreadNotebookKernelsShape;
private readonly _kernelData = new Map<number, { id: string, executeHandler: ExecuteHandler, interruptHandler?: InterruptHandler, selected: boolean, onDidChangeSelection: Emitter<boolean> }>();
private readonly _kernelData = new Map<number, { id: string, executeHandler: ExecuteHandler, interruptHandler?: InterruptHandler, onDidChangeSelection: Emitter<{ selected: boolean, uri: URI }> }>();
private _handlePool: number = 0;
constructor(
@@ -39,8 +39,8 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
let isDisposed = false;
const commandDisposables = new DisposableStore();
const emitter = new Emitter<boolean>();
this._kernelData.set(handle, { id: options.id, executeHandler: options.executeHandler, selected: false, onDidChangeSelection: emitter });
const emitter = new Emitter<{ selected: boolean, uri: URI }>();
this._kernelData.set(handle, { id: options.id, executeHandler: options.executeHandler, onDidChangeSelection: emitter });
const data: INotebookKernelDto2 = {
id: options.id,
@@ -73,7 +73,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
return {
get id() { return data.id; },
get selector() { return data.selector; },
// get selected() { return that._kernelData.get(handle)?.selected ?? false; },
// onDidChangeSelection: emitter.event,
get label() {
return data.label;
@@ -128,11 +128,13 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
};
}
$acceptSelection(handle: number, value: boolean): void {
$acceptSelection(handle: number, uri: UriComponents, value: boolean): void {
const obj = this._kernelData.get(handle);
if (obj) {
obj.selected = value;
obj.onDidChangeSelection.fire(value);
obj.onDidChangeSelection.fire({
selected: value,
uri: URI.revive(uri)
});
}
}