From fdc96f0c23b403c9d1712534fea72f2a422c1673 Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Fri, 26 Sep 2025 14:08:33 -0700 Subject: [PATCH] Enable gfm and single newline breaks for chat responses too (#268546) Fix #266990 --- .../browser/chatContentParts/chatMarkdownContentPart.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/contrib/chat/browser/chatContentParts/chatMarkdownContentPart.ts b/src/vs/workbench/contrib/chat/browser/chatContentParts/chatMarkdownContentPart.ts index 7bae0a16e13..8793c5fc2b6 100644 --- a/src/vs/workbench/contrib/chat/browser/chatContentParts/chatMarkdownContentPart.ts +++ b/src/vs/workbench/contrib/chat/browser/chatContentParts/chatMarkdownContentPart.ts @@ -26,6 +26,7 @@ import { ITextModel } from '../../../../../editor/common/model.js'; import { getIconClasses } from '../../../../../editor/common/services/getIconClasses.js'; import { IModelService } from '../../../../../editor/common/services/model.js'; import { ITextModelService } from '../../../../../editor/common/services/resolverService.js'; +import { EditDeltaInfo } from '../../../../../editor/common/textModelEditSource.js'; import { localize } from '../../../../../nls.js'; import { getFlatContextMenuActions } from '../../../../../platform/actions/browser/menuEntryActionViewItem.js'; import { IMenuService, MenuId } from '../../../../../platform/actions/common/actions.js'; @@ -38,7 +39,6 @@ import { IInstantiationService } from '../../../../../platform/instantiation/com import { ILabelService } from '../../../../../platform/label/common/label.js'; import { IEditorService } from '../../../../services/editor/common/editorService.js'; import { IAiEditTelemetryService } from '../../../editTelemetry/browser/telemetry/aiEditTelemetry/aiEditTelemetryService.js'; -import { EditDeltaInfo } from '../../../../../editor/common/textModelEditSource.js'; import { MarkedKatexSupport } from '../../../markdown/browser/markedKatexSupport.js'; import { IMarkdownVulnerability } from '../../common/annotations.js'; import { IEditSessionEntryDiff } from '../../common/chatEditingService.js'; @@ -127,11 +127,11 @@ export class ChatMarkdownContentPart extends Disposable implements IChatContentP })]) : []; - // Don't set to 'false' for responses, respect defaults - const markedOpts: MarkdownRendererMarkedOptions = isRequestVM(element) ? { + // Enables github-flavored-markdown + line breaks with single newlines (which matches typical expectations but isn't "proper" in markdown) + const markedOpts: MarkdownRendererMarkedOptions = { gfm: true, breaks: true, - } : {}; + }; const result = this._register(renderer.render(markdown.content, { sanitizerConfig: MarkedKatexSupport.getSanitizerOptions({