Commit Graph

38 Commits

Author SHA1 Message Date
Matt Bierner
2648263d3e Run our build scripts directly as typescript (#277567)
* Run our build scripts directly as typescript #277567

Follow up on #276864
For #277526

* Remove a few more ts-node references

* Fix linux and script reference

* Remove `_build-script` ref

* Fix script missing closing quote

* use type only import

* Fix export

* Make sure to run copy-policy-dto

* Make sure we run the copy-policy-dto script

* Enable `verbatimModuleSyntax`

* Pipelines fixes

* Try adding explicit ext to path

* Fix bad edit

* Revert extra `--`

---------

Co-authored-by: João Moreno <joaomoreno@users.noreply.github.com>
2025-11-21 14:56:00 +01:00
Johannes Rieken
aabd4ec6a7 no more any-casts in propertyInitOrderChecker, https://github.com/microsoft/vscode/issues/269213 (#270198) 2025-10-07 10:42:38 -04:00
Matt Bierner
360c9fd134 Add lint rule for as any and bulk ignore all existing breaks
For #269213

This adds a new eslint rule for `as any` and `<any>({... })`. We'd like to remove almost all of these, however right now the first goal is to prevent them in new code. That's why with this first PR I simply add `eslint-disable` comments for all breaks

Trying to get this change in soon after branching off for release to hopefully minimize disruption during debt week work
2025-10-02 23:38:33 -07:00
Matt Bierner
f91e6f01b8 Fix enum init order 2025-08-06 12:00:36 -07:00
Matt Bierner
bd031dafbc Convert const enums 2025-08-06 11:47:45 -07:00
Johannes Rieken
505092bbf7 Towards useDefineForClassFields (#248695)
* final init order fixes https://github.com/microsoft/vscode/issues/243049

* a few more fixed when compiling with `"useDefineForClassFields": true`

https://github.com/microsoft/vscode/issues/243049 and https://github.com/microsoft/vscode/issues/186726

* add a dry-check that ensures we can/could compile/emit with explicitly defined class fields

https://github.com/microsoft/vscode/issues/186726
2025-05-12 11:46:15 +02:00
Johannes Rieken
b2cc6acd95 fix property order (#248518)
https://github.com/microsoft/vscode/issues/243049
2025-05-09 16:29:18 +02:00
Henning Dieterichs
ec56ae1173 Removes fixed files from propertyInitOrderChecker ignored list. (#248491) 2025-05-09 10:32:23 +00:00
Megan Rogge
edcb3e4aa9 ensure properties are initialized before usage (#247312) 2025-04-24 16:49:23 +02:00
Aiday Marlen Kyzy
0fcff83aab Fixing property initializiation order (#245673)
fixing property initializiation order
2025-04-04 15:12:47 +02:00
Johannes Rieken
3561b4e9cd fix property init orders (#245412)
* fix property init order in `anythingQuickAccess.ts`

https://github.com/microsoft/vscode/issues/243049

* update list

https://github.com/microsoft/vscode/issues/243049
2025-04-03 09:10:34 +02:00
Johannes Rieken
ae58d15a98 remove unused property (#245411)
https://github.com/microsoft/vscode/issues/243049
2025-04-03 09:09:59 +02:00
Oleg Solomko
7ec70cbc51 fix class property order issue for the PromptsService class 2025-04-02 10:08:59 -07:00
Oleg Solomko
a0a58191db fix class property order issue for the PromptReference class 2025-04-02 10:08:59 -07:00
Oleg Solomko
c0b74b7db1 fix class property order issue for the TextModelContentsProvider class 2025-04-02 10:08:59 -07:00
Sandeep Somavarapu
a1d5b448c1 Fix property init order (#245255) 2025-04-01 19:55:30 +02:00
Johannes Rieken
b8cdd08a18 prepare for init order changes in terminalTypeAheadAddon.ts (#245228)
fyi @Tyriar

https://github.com/microsoft/vscode/issues/243049
2025-04-01 12:29:49 +02:00
Connor Peet
966a672107 testing/debug: cleanup property initialisation order changes (#245186)
Refs #243049
2025-04-01 01:19:15 +02:00
Johannes Rieken
80adefd46b fix property order in arrays (#245117)
https://github.com/microsoft/vscode/issues/243049
2025-03-31 13:20:36 +02:00
Martin Aeschlimann
92815973e1 remoteIndicator: Debt - prepare for property initialisation order changes (#243463) 2025-03-13 16:55:18 +01:00
Benjamin Christopher Simmonds
7c64719ac9 insertion view init order fix (#243316)
init order
2025-03-12 11:04:04 +01:00
Benjamin Christopher Simmonds
52e197c533 Fix initialization orders for inline edits (#243310)
fix init orders
2025-03-12 10:37:16 +01:00
Benjamin Pasero
0e6e6d2bff debt - prepare for property initialisation order changes #243049 (#243184)
* debt - prepare for property initialisation order changes #243049

* missing

* omg?
2025-03-11 14:32:59 +00:00
Benjamin Pasero
129f975fd4 debt - prepare for property initialisation order changes #243049 (#243153) 2025-03-11 08:51:56 +00:00
Peng Lyu
0bec97c0bf re #243049. property initialisation order for file user data provider. (#243101) 2025-03-10 19:22:52 +01:00
Alex Ross
897d7c8abf Fix some property init order debt in comments files (#243095)
Part of #243049
2025-03-10 18:03:17 +01:00
Alex Ross
62e914e344 Make the property init order checker script Windows friendly (#243093)
Part of #243049
2025-03-10 17:54:49 +01:00
Alexandru Dima
1e271e0428 Adopt initialisation order changes (#243090)
Adopt initialisation order changes (#243049)
2025-03-10 17:45:37 +01:00
Ladislau Szomoru
6306af46f0 SCM - 💄 fix property init order in scmHistoryViewPane.ts (#243069) 2025-03-10 06:23:53 -07:00
Aiday Marlen Kyzy
50a7fe5744 Fixing property initialization order check in ghostText.ts (#243068)
fixing property initialization order check in ghostText.ts
2025-03-10 14:04:32 +01:00
Robo
0018d20957 chore: fix property init order in ipc.mp.ts (#243066) 2025-03-10 13:57:36 +01:00
Aiday Marlen Kyzy
4ffd9dd633 Fixing property initialization order in stickyScrollWidget.ts file (#243067)
* running property init order check on sticky scroll widget

* refactoring
2025-03-10 13:53:34 +01:00
Ladislau Szomoru
fb57e96676 SCM - 💄 fix property init order in workingSet.ts (#243061) 2025-03-10 13:14:59 +01:00
Ladislau Szomoru
887fa0736e SCM - 💄 fix property init order in scmViewService.ts (#243060) 2025-03-10 13:10:05 +01:00
Ladislau Szomoru
06e9d7ece1 SCM - 💄 fix property init order in quickDiffDecorator.ts (#243058) 2025-03-10 12:46:39 +01:00
Ladislau Szomoru
8d69af582f SCM - 💄 fix property init order in activity.ts (#243056) 2025-03-10 12:27:12 +01:00
Johannes Rieken
2cde379d3a fix property init order for chatEditingCodeEditorIntegration (#243051)
* add explaining comment

* fix property init order for `chatEditingCodeEditorIntegration`

https://github.com/microsoft/vscode/issues/243049
2025-03-10 11:37:20 +01:00
Johannes Rieken
c04ac5a5df add property-init-order-check and run during CI (just like valid layers check) (#243042)
Enable ignore list which capture current violations and todo list
2025-03-10 10:22:18 +01:00