Commit Graph

55 Commits

Author SHA1 Message Date
Benjamin Pasero
898436fbe6 Clean up code layering suppressions (fix #272777) (#272834)
* Clean up code layering suppressions (fix #272777)

* Update test/unit/electron/index.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-23 09:28:38 +02:00
Aman Karmani
7deabf42e7 [engineering] add testSplit option to unit-test runner (#253049)
helpful to run tests in parallel
2025-07-07 20:34:30 +00:00
Ladislau Szomoru
4d7c56ee82 Engineering - Add GitHub action for pull requests (#254056)
* Test - handle running tests as part of a GitHub action

* Add GitHub action files
2025-07-04 08:21:56 +00:00
Benjamin Pasero
6b924c5152 ESM merge to main (#227184)
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-08-30 10:31:46 +02:00
Benjamin Pasero
9f04aaf6f4 tests - depend on a test preload.js (#226588) 2024-08-26 10:14:27 +02:00
Connor Peet
358a3a65d3 fix incomplete coverage reports on macos (#212639)
* eng: fix incomplete coverage reports on macos

Wait for stdout to drain before exiting

* better fix
2024-05-13 15:27:00 -07:00
Connor Peet
2aa1079dbb just use v8-to-istanbul 2024-05-08 15:42:43 -07:00
Connor Peet
0385382382 testing: more out-of-editor refinements (#201834)
- Som more tweaks to our own runner scripts to allow asking for the
  generated coverage formats.
- Add actions alongside debug/run for executing coverage profiles
- Finish with displaying function coverage stats in Coverage view,
  allow changing its sort order.

Fixes #200529
Fixes #199380
2024-01-04 21:22:46 +01:00
Connor Peet
c016ce64fb testing: misc work on test coverage (#201758)
- Allow coverage bar color thresholds to be configurable as the Java
  folks requested.
- Update some of our scripts for integration into
  the selfhost test runner.
- Initial parts of showing function coverage in the Test Coverage view.
  (Still a work in progress, more tomorrow)
2024-01-04 08:42:22 +01:00
Connor Peet
b964ed995a eng: fix waitServer not working in unit test debug (#201334)
Fixes #182341
2023-12-20 14:09:46 -08:00
Johannes Rieken
3056f52f92 add failing/skipped test for https://github.com/microsoft/vscode/issues/191070 (#200125)
* fix --dev option of unit tests fyi @joaomoreno

* fix timing issue when getting line, add failing/skipped test for https://github.com/microsoft/vscode/issues/191070
2023-12-06 12:16:49 +01:00
João Moreno
a5d71aad39 Cleanup dependencies (#195026)
* move build dependencies to devDependencies

* build: bump tree-sitter

* dependencies cleanup

* remove leftover file
2023-10-09 09:34:15 +02:00
Benjamin Pasero
b0b69338e8 debt - further reduce electron-browser layer (#178504)
* debt - move more tests out of `electron-browser`

* move more tests

* move preload script as well

* fix
2023-03-28 10:35:58 -07:00
Johannes Rieken
1857d6c076 for test runinng, use --dev instead of --debug (#159040)
fixes https://github.com/microsoft/vscode/issues/159011
2022-08-24 07:54:39 -04:00
deepak1556
1044556d8b chore: bump electron@18.0.0-beta.4 2022-05-31 08:25:29 +09:00
Robo
32d40cf44e chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Robo
df645f1450 chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Benjamin Pasero
b344f43498 Revert "linux: disable crash reporting in CI (#142572)"
This reverts commit 7dbd7367dc.
2022-02-15 16:27:08 +01:00
Benjamin Pasero
7dbd7367dc linux: disable crash reporting in CI (#142572) 2022-02-15 08:26:18 +01:00
Robo
01df559c18 chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Benjamin Pasero
ddbda4c196 tests - enable crash reporter for electron based unit tests
//cc @deepak1556
2021-11-19 11:12:53 +01:00
Henning Dieterichs
98c1725c7d Encode actual and expected value as JSON to enable https://github.com/microsoft/vscode-selfhost-test-provider/pull/2.
Only a proof of concept yet.
2021-09-13 18:44:06 +02:00
Connor Peet
fa9255c0de almost complete update for run configurations 2021-07-12 17:28:01 -07:00
Connor Peet
20790ec994 testing: increase debugger wait timeout 2021-07-09 15:28:35 -07:00
Benjamin Pasero
d0df79be50 webview - remove more traces (#128128)
* webview - remove more traces

* more removal
2021-07-07 18:28:53 +02:00
Benjamin Pasero
802648f2a1 electron - adopt some newer APIs and 💄 main code 2021-06-04 09:22:38 +02:00
Connor Peet
24ea8408c3 testing: propoagate timeout option for unit tests 2021-04-29 12:19:56 -07:00
Connor Peet
b1569995f9 testing: allow waiting for server before running unit tests
Fixes https://github.com/microsoft/vscode/issues/121751
2021-04-26 16:31:36 -07:00
Benjamin Pasero
7095f4706c unit tests (electron) - avoid sending circular structures over 2021-04-21 08:13:08 +02:00
Benjamin Pasero
f8c7dd64a4 tests - ensure preload promises are all resolved 2021-04-09 08:28:21 +02:00
Benjamin Pasero
ff0f7f3cf2 Make product configuration available to non node.js environments (fix #120243) 2021-04-06 08:55:31 +02:00
Benjamin Pasero
1db94dbb10 sandbox - add additional arguments also to test runner 2021-04-01 08:10:40 +02:00
Connor Peet
48e8463a89 testing: tear down app if renderer crashes
Fixes https://github.com/microsoft/vscode/issues/117068
2021-03-29 16:41:03 -07:00
Connor Peet
2b5ae783bf testing: add full json reporter to show more complete output 2021-01-13 15:30:11 -08:00
Connor Peet
04d7411785 eng: update mocha 2 -> 8 2020-12-17 11:24:15 -08:00
Benjamin Pasero
87847325a6 electron - set spellcheck: false again for windows 2020-09-11 09:49:18 +02:00
Ladislau Szomoru
41b661eb3d Add process.arch into unit test results file names 2020-08-18 18:08:37 +02:00
Robo
e4296330de chore: update to electron 9-x-y (#102011)
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2020-08-11 11:30:23 -07:00
Ladislau Szomoru
cf4e4c1754 Add JUnit reporter for unit tests (#104354) 2020-08-10 11:20:34 +02:00
Robo
227d533937 Revert "chore: update to electron 9-x-y (#102011)" (#103599)
This reverts commit 3d0d50caf8.
2020-07-30 08:35:43 -07:00
João Moreno
c1f44f4e3e Merge pull request #103436 from codebytere/fix-json-reporter
fix: add missing property to deserializeRunnable
2020-07-30 10:06:18 +02:00
Shelley Vohr
3770547cc1 fix: add missing property to deserializeRunnable 2020-07-27 20:13:27 -07:00
Robo
3d0d50caf8 chore: update to electron 9-x-y (#102011)
* chore: bump electron@9.0.5

* remove exploration config

* fix compile error

* fix compile error

* crashReporter has to be called only once before app ready

* chore: bump electron@9.1.0

* enable LayoutNG

* fix cron schedule

* allow disabling appcenter crash reporting

* set additional crash reporting parameters

* start crashreporter for child process on linux

* setup crash parameters only once

* remove unused crashReporter.guid

* address review feedback

* reuse argv.json for storing crash reporter id

* remove trailing commas

* update localized name

* update argv based on telemetry optout

* update initial config based on setting

* fix conditional errors

* remove telemetry.enableCrashReporter

* move default crash reporter config to electron-main

* update comment for ext host crash reporting

* set default value for configuration

* some 💄 changes

* address review feedback

* do not use ES7 features in JS yet

* add app.focus({ steal: true }) usage

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2020-07-21 09:39:34 +02:00
Benjamin Pasero
a006879172 electron - explicitly disable spellchecker
It will be enabled by default starting with Electron 9
2020-07-21 07:50:25 +02:00
Benjamin Pasero
4aab95966b unit tests - run them in same environment as our main code 2020-07-20 10:57:10 +02:00
Benjamin Pasero
e5b3ff76ba Enable sandbox and contextIsolation for process explorer when running with --__sandbox (#102924)
* sandbox - allow to enable sandbox and contextIsolation for process explorer

* fix asar lookup
2020-07-20 10:30:20 +02:00
Benjamin Pasero
4f65b91444 electron - disable remote module in all windows (#101224) 2020-06-28 12:12:38 +02:00
Benjamin Pasero
7f49ef52e3 sandbox - configure nativeWindowOpen:true
This matches the behaviour of sandboxed Electron renderers.
2020-06-16 18:52:34 +02:00
deepak1556
113fd1b7bc chore: bump electron@7.3.0 2020-05-27 12:47:39 -07:00
Benjamin Pasero
d637255b17 Merge branch 'master' into ben/electron-sandbox 2020-05-27 06:51:08 +02:00