MohamedEmirHajji
7da4bbe808
Markdown preview: filter hidden elements from scroll sync (fix microsoft#281247)
2025-12-10 17:01:55 +01:00
MohamedEmirHajji
e04a029f0e
Markdown preview: filter hidden elements from scroll sync ( fix #281247 )
2025-12-10 15:54:00 +01:00
Matt Bierner
98b069c041
Work towards getting isolated built-in extension compiles
...
For #271167
This makes it so our built-in extensions can mostly be built using `tsc` on the command line. Previously the extensions were picking up a lot of typing info from the root `node_modules` that meant they weren't truly independent
2025-10-13 11:03:20 -07:00
Matt Bierner
598304ba4d
Merge pull request #269665 from mjbvz/dev/mjbvz/delicious-sloth
...
Add lint rule for `as any` and bulk ignore all existing breaks
2025-10-03 01:31:51 -07:00
Copilot
3a1b1ed83c
Disable double-click to reveal source for .copilotmd files in markdown preview ( #267517 )
...
* Initial plan
* Disable double-click behavior for .copilotmd files in markdown preview
Co-authored-by: joaomoreno <22350+joaomoreno@users.noreply.github.com >
* Update extensions/markdown-language-features/preview-src/index.ts
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: joaomoreno <22350+joaomoreno@users.noreply.github.com >
Co-authored-by: João Moreno <joaomoreno@users.noreply.github.com >
2025-10-03 08:27:59 +00:00
Matt Bierner
360c9fd134
Add lint rule for as any and bulk ignore all existing breaks
...
For #269213
This adds a new eslint rule for `as any` and `<any>({... })`. We'd like to remove almost all of these, however right now the first goal is to prevent them in new code. That's why with this first PR I simply add `eslint-disable` comments for all breaks
Trying to get this change in soon after branching off for release to hopefully minimize disruption during debt week work
2025-10-02 23:38:33 -07:00
Matt Bierner
73e6d6a0a2
Enable a few more stylistic eslint options for my extensions
2025-08-14 10:42:20 -07:00
Matt Bierner
30b93b1217
Bump extensions to target es2024
...
I reviewed the various changes and library additions of es2024 and it seems they are widely supported across node and modern browsers
2025-08-05 10:40:33 -07:00
heoh
53a4ef7018
Fix markdown preview scroll crawls at EOF ( fix #249278 )
2025-06-12 03:56:11 +09:00
Matt Bierner
42c4a17dd9
Merge pull request #240508 from notoriousmango/copy-image-handle-error
...
fix: use the copy command for images with CORS errors in the markdown preview
2025-03-25 13:35:14 -07:00
Matt Bierner
23812e0d8f
Make sure scripts in md preview are properly evaluated
...
Fixes #243454
This restores the previous behavior. If the default security settings are used, scripts will still block blocked by the CSP. If you fully disable the security settings, then we'll try to run them
2025-03-17 11:45:49 -07:00
Seong Min Park
de60000148
Merge branch 'main' into copy-image-handle-error
2025-03-16 16:04:34 +09:00
Matt Bierner
0a66642a04
Don't duplicate body in md preview
...
Fixes #243340
2025-03-12 09:07:34 -07:00
notoriousmango
0928609c9b
use selection to copy from web view
2025-02-12 19:09:31 +09:00
Matt Bierner
d70e0e2fe0
Merge pull request #236406 from mjbvz/confidential-trout
...
Small cleanup follow up on #236145
2024-12-17 12:22:16 -08:00
Matt Bierner
a47b13ebc2
Small cleanup follow up on #236145
...
- Don't send content as json
- Reuse existing load helper
2024-12-17 11:59:05 -08:00
Matt Bierner
4559089128
Merge pull request #234649 from notoriousmango/feat-open-image
...
Add 'open image' context in markdown preview
2024-12-17 11:55:25 -08:00
Parasaran
ca72122751
fix 235221: Encode and decode markdown content to escape illegal chars
2024-12-17 23:32:42 +05:30
Parasaran
da1d8b9c8e
fix 235221: Passing the markdown content to the webview via meta tag and purifying it before use
2024-12-17 22:57:12 +05:30
notoriousmango
f7c3b1b474
use openDocumentLink
2024-12-15 00:11:54 +09:00
notoriousmango
0b243279cc
open image
2024-11-26 19:53:31 +09:00
Sandeep Somavarapu
841d51da29
write our own little gulp-eslint which takes the eslint from our workspace root ( #230115 )
2024-09-30 15:36:25 +02:00
Gianluca Cappai
59f6431095
Fix open html anchor link in markdown preview ( #228633 )
...
use node.getAttribute instead of node.href
Co-authored-by: Gianluca Cappai <gcappai.dev@@gmail.com>
Co-authored-by: Matt Bierner <matb@microsoft.com >
2024-09-18 14:37:55 -07:00
Matt Bierner
5ee455116f
Add codeql comments and small fix ( #185931 )
2023-06-23 02:40:39 +02:00
MeghanKulkarni
67cc0965b3
allow images in markdown preview editor to be copied ( #184432 )
...
* allow images in markdown preview editor to be copied
* resolved feedback
* added findPreview method
* removed copy image command from showPreview
* clean up
---------
Co-authored-by: Meghan Kulkarni <t-mekulkarni@microsoft.com >
2023-06-07 18:08:22 +00:00
Matt Bierner
87a6bda310
Fix opening encoded markdown fragment in preview ( #178465 )
...
Fixes #178340
2023-03-28 08:59:30 +02:00
Matt Bierner
1379bf3f15
Fix markdown webview state updates ( #178153 )
...
Fixes #164071
Also fixes the webview not scrolling when the resources changes
2023-03-23 17:51:09 +00:00
Matt Bierner
924ee8b4d8
Don't scroll sync to elements inside collapsed details sections ( #176541 )
...
Fixes #176538
Turns out that `getClientBoundingRect` returns weird bounds for elements inside of a collapsed details section
2023-03-08 21:06:26 +01:00
Matt Bierner
3ca5284e44
Clean up markdown preview messaging ( #176458 )
...
- Add properties directly to message
- Add `ImageInfo` type
- Don't use state to pass around imageInfo
2023-03-07 17:28:13 -08:00
Matt Bierner
6a44101bb1
Type markdown preview webview message ( #176444 )
...
Simply types messages. Will clean up types in next pass
2023-03-07 14:23:17 -08:00
Matt Bierner
83c4e0f5c4
Reset markdown scroll progress on resource change ( #176437 )
...
Reset scroll progress on resource change
Fixes #164071
2023-03-07 23:12:46 +01:00
Matt Bierner
d0ad7c09bb
Fix details blocks being auto closed on markdown preview changes ( #176330 )
...
Fixes #175353
2023-03-07 02:36:38 +01:00
Ely Ronnen
5b79b91838
Fix #173869 marking active line for code elements too in markdown pre… ( #173870 )
...
Fix #173869 marking active line for code elements too in markdown preview
2023-02-08 20:25:54 +00:00
ibuky
9894ae8700
fix#171379 ( #172175 )
...
Co-authored-by: VTX0 <VTX0>
2023-02-01 00:35:02 +00:00
Matt Bierner
ac88f33e2c
Revert "Fix: New md file scrolls to Top. ( #164999 )" ( #168224 )
...
This reverts commit 54543cf5bf .
2022-12-06 22:50:30 +01:00
Matt Bierner
107d3ab28c
Fix markdown scrolling between elements being too jumpy ( #166746 )
...
Fixes #165055
We need to consider the distance between the end of the previous element and start of the next element. Previously we were taking distance from start of the previous to start of the next
2022-11-18 13:02:56 -08:00
Debayan Ganguly
54543cf5bf
Fix: New md file scrolls to Top. ( #164999 )
...
Fixes #164071 .
2022-11-09 13:48:39 -08:00
Matt Bierner
4991cf2112
Remove console.log ( #162784 )
2022-10-05 15:25:52 -07:00
Matt Bierner
f4bf1f30a2
Skip ul and ol when highlighting selected markdown element ( #161139 )
...
Fixes #155552
For lists, the outer ul/ol always has the same source line as the first element in the list. We should prefer using the first element in the list when highlighting the active line
This also fixes a bug where scroll sync would stop working if you added lines to the doc. This was caused by `lineCount` getting out of sync as the document is being updated. I've removed this state and made the reveal logic more robust instead
2022-09-19 07:16:06 +02:00
Matt Bierner
f17b33faf2
Use .?method() in more places ( #152112 )
...
Switches simple patterns like:
```ts
if (some.thing) {
some.thing.method();
}
```
to:
```ts
some.thing?.method()
```
This is more concise and avoids having to repeat the `some.thing` part
2022-06-15 16:28:31 +00:00
Johannes Rieken
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391
2022-02-02 14:35:33 +01:00
Matt Bierner
e7b3724e0c
Enable no-case-declarations in codebase ( #139243 )
...
Fixes #139236
This can catch tricky programming mistakes that cause a runtime error. See 7e266b2c42 as an example of the type of bug this can prevent
2021-12-15 17:15:35 -08:00
Matt Bierner
913639f42a
Strip meta http-equiv tags from webview content updates
2021-12-14 11:53:49 -08:00
Matt Bierner
71f615b105
Also compare other attributes for md preview updates
...
Fixes #136816
2021-11-10 14:13:41 -08:00
Matt Bierner
c11a9ce097
Better update of line numbers
2021-11-04 14:34:49 -07:00
Matt Bierner
4d50e586ec
Improve morphing for vscode-docs
2021-11-03 20:54:20 -07:00
Matt Bierner
fbc1f7df91
Fire event when md content is updated
...
For #136255
2021-11-01 17:41:39 -07:00
Matt Bierner
8f672cac62
Use morphdom to reduce number of full page updates to md preview
...
This should help improve scroll sync and also reduce the number of times we go out to the network if images are in the preview
2021-11-01 15:33:00 -07:00
Matt Bierner
92418e0ea0
Remove usage of non-standard setImmediate
...
This was broken after upgrading to webpack5
2021-07-06 12:42:27 -07:00
Matt Bierner
b8f11107f7
Use @types/vscode-webview
2021-05-27 13:41:38 -07:00