Commit Graph

156 Commits

Author SHA1 Message Date
Copilot
0231690206 Fix ipynb deserialization crash when cells lack metadata field (#282878)
* Initial plan

* Fix ipynb deserialization when cells lack metadata field

Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>

* Fix test

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
2025-12-12 05:36:03 +00:00
Don Jayamanne
dd2c3af375 Remove as any from ipynb (#277057)
* Remove `as any` from ipynb

* Fixes

* updates
2025-11-13 09:30:35 +01:00
Don Jayamanne
b282eee40c Remove usages of in (#276333)
* Remove usages of in

* Update extensions/ipynb/src/serializers.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-09 08:07:11 +01:00
Matt Bierner
360c9fd134 Add lint rule for as any and bulk ignore all existing breaks
For #269213

This adds a new eslint rule for `as any` and `<any>({... })`. We'd like to remove almost all of these, however right now the first goal is to prevent them in new code. That's why with this first PR I simply add `eslint-disable` comments for all breaks

Trying to get this change in soon after branching off for release to hopefully minimize disruption during debt week work
2025-10-02 23:38:33 -07:00
Ladislau Szomoru
4d7c56ee82 Engineering - Add GitHub action for pull requests (#254056)
* Test - handle running tests as part of a GitHub action

* Add GitHub action files
2025-07-04 08:21:56 +00:00
Don Jayamanne
bdc1dd9a7c Enable ipynb serialization (forgot to change value in code) (#251959) 2025-06-19 19:38:44 -07:00
Don Jayamanne
4ff7a87b13 Ensure we always normalize cell source (#251670)
* Ensure we always normalize cell source

* oops
2025-06-17 05:46:59 +02:00
Aaron Munger
fa298e0de0 skip flaky test (#251158) 2025-06-10 15:50:26 -07:00
Aaron Munger
10066c9ec3 more certainty for resuming the paused emitter (#251130) 2025-06-10 12:30:54 -07:00
Don Jayamanne
509cc674f2 Skip failing nb test untill resolved (#248472) 2025-05-09 15:15:05 +10:00
Aaron Munger
e65a9a3d46 check one more async op (#248225) 2025-05-06 17:46:21 +02:00
Aaron Munger
d6fb62df0d diagnostic message (#248151) 2025-05-05 20:22:41 +02:00
Aaron Munger
e5ac650981 bump default nb format version (#242741)
* bump default nb format version

* update tests

---------

Co-authored-by: amunger <>
2025-03-07 20:58:55 +01:00
Aaron Munger
469d54e912 call the generator function (#242912)
call the function

Co-authored-by: amunger <>
2025-03-07 10:54:22 -08:00
Raymond Zhao
54b12e5ec8 Copy UUID impl (#231347) 2025-03-03 09:29:59 -08:00
Oleg Solomko
1195e2cf77 fix the the the typos (#239646)
fix the `the the` -> `the` typos
2025-02-04 15:35:23 -08:00
Don Jayamanne
8cc255e03a Ensure execution_count is cleared when clearing outputs (#237301) 2025-01-05 19:58:34 -08:00
Don Jayamanne
008340a55c Ensure notebook execution count is cleared only when necessary (#234776) 2024-11-27 18:45:53 +01:00
Matt Bierner
c83b443da0 Clean up support for paste edits (#234240)
- Allow setting an array of preferences for paste as keybindings
- Clarifies kinds used for core and extensions
- Exports text kind as API
2024-11-20 07:14:10 +01:00
Don Jayamanne
27d99fbee7 Set execution_count to null when clearning notebook outputs (#231806)
* Set execution_count to null when clearning notebook outputs

* Fix tests
2024-10-21 06:56:16 +02:00
Johannes
e6f315d2fc eng - use esModuleInterop for extensions 2024-10-01 21:57:30 +02:00
Don Jayamanne
620fd6cb9a Support serialization of IPYNB in web worker (#230190) 2024-10-01 21:22:55 +10:00
Don Jayamanne
c35d5e21fc Exclude cells and indentAmount from notebook metadta diff view (#230173) 2024-09-30 15:50:47 -07:00
Matt Bierner
51fa4d0172 Fix more type assertions (#230156)
* Fix more type assertions

For #211878

* Fix type error
2024-09-30 14:17:06 -07:00
Don Jayamanne
c4645ea0ec Restore changes to ipynb extension to serialize notebook in node worker for desktop (#228319)
* Revert usage of node worker due to failing web compilation

* Revert "Revert usage of node worker due to failing web compilation"

This reverts commit 3190f58c7e.

* Ensure node worker is used only in desktop bundle of ipynb extension

---------

Co-authored-by: Aaron Munger <aamunger@microsoft.com>
2024-09-12 23:56:34 +02:00
Don Jayamanne
102ff8db3f Revert usage of node worker due to failing web compilation (#228318)
* Revert usage of node worker due to failing web compilation

* fix linter error
2024-09-12 17:44:02 +09:00
Don Jayamanne
edd3903933 Updates 2024-09-10 01:19:53 +10:00
Don Jayamanne
692656799a Safer way to determine whether node or browser 2024-09-09 12:07:43 +10:00
Don Jayamanne
1865c2979d Import node worker 2024-09-09 11:48:21 +10:00
Don Jayamanne
ddd0f1fe34 Updates to perform all operations in worker 2024-09-09 11:37:44 +10:00
nojaf
cdc45ffb42 Include ending new line 2024-09-05 10:46:28 +02:00
nojaf
12abcccc81 Duplicate sortObjectPropertiesRecursively 2024-09-04 09:15:29 +02:00
nojaf
e3caeae15d Verify that node worker is only used in node context. 2024-09-04 09:15:29 +02:00
nojaf
c363defd73 Update worker file to esm 2024-09-04 09:15:29 +02:00
nojaf
366df5a69d Put worker behind setting 2024-09-04 09:15:29 +02:00
nojaf
eb948e1ab7 Use Worker to serialize Notebook 2024-09-04 09:15:27 +02:00
Don Jayamanne
9b2e9634aa Remove code used to store metadata in custom property for notebooks (#227418)
* Remove code used to store metadata in custom property for notebooks

* oops
2024-09-03 09:24:35 +02:00
Don Jayamanne
c0e1202c12 Stop adding a default cell in notebooks (#226692) 2024-09-02 08:20:26 +02:00
Don Jayamanne
2503ccd9d0 Support reverting Jupyter execution count via nb diff editor (#227157)
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2024-09-02 06:23:17 +02:00
Don Jayamanne
5809a68666 wip 2024-08-23 05:59:29 +10:00
Aaron Munger
d7ade261f8 remove giant unused context key (#214504) 2024-06-12 08:34:29 -07:00
Don Jayamanne
804f8e3929 Debounce notebook cell metadata edit updates (#210005)
* Debounce notebook cell metadata edit updates

* Clear timer

* Check notebook type

* Try again

* Ignore IW notebooks

* oops
2024-04-11 07:44:14 +02:00
Don Jayamanne
e079f1e07b Drop custom property from Jupyter Nb metadata (#210011) 2024-04-10 08:30:18 +02:00
Matt Bierner
8c363b460b Merge and cleanup drop and paste proposal (#209591)
These two proposals overlap a lot and will be finalized together
2024-04-05 13:03:10 -07:00
Don Jayamanne
e3cf2530e6 Include execution count in jupyter notebook diff (#208292)
* Include execution count in notebook diff

* Fix tests

* Misc changes

* Fix tests

* Fix more tests
2024-03-21 14:14:33 +01:00
Don Jayamanne
c0fa2a7b47 Expose prop to determine if custom prop is used (#208145) 2024-03-19 17:12:07 -07:00
Don Jayamanne
0f6d7c03fc Rename property to lineup with other exp props (#208121) 2024-03-19 20:31:31 +01:00
Don Jayamanne
55d6f3050d Drop custom metadata property from notebooks behind setting (#208065)
* Drop custom metadata property behind setting

* Do not update existing object
2024-03-19 19:37:59 +11:00
Don Jayamanne
1e95cb902e Keep notebook model in sync with the ipynb json (#208052) 2024-03-18 20:17:46 -07:00
Don Jayamanne
3242621276 Remove unwanted vscode property when not required (#208014) 2024-03-18 08:50:28 -07:00