Commit Graph

262 Commits

Author SHA1 Message Date
Benjamin Pasero
9727eb6050 untitled - fix save with associated file path 2019-11-18 07:57:48 +01:00
Matt Bierner
27a33ee6fe Hook up very basic undo/redo for webview editors
For #77131
2019-11-15 18:21:46 -08:00
Benjamin Pasero
72c2f506de working copy - introduce first save/revert semantics (#84672) 2019-11-15 15:36:55 +01:00
Johannes Rieken
e80c62bdcb allow $openUri to accept URI and string 2019-11-15 10:53:04 +01:00
Johannes Rieken
e51ef85bcb Revert "allow $openUri to accept a URI and string, adopt consumer but keep the API as is"
This reverts commit 544b0abf5b.
2019-11-15 10:29:29 +01:00
Johannes Rieken
544b0abf5b allow $openUri to accept a URI and string, adopt consumer but keep the API as is 2019-11-15 10:28:03 +01:00
Alex Dima
15beb36ccf Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-14 09:16:10 +01:00
Matt Bierner
278b4f8cfa Hookup experimental undo for customEditors
This currently is not connected to any actual actions in the editor
2019-11-07 17:22:21 -08:00
Matt Bierner
bca7206f59 Forward onEdit from webviewEditor to mainthread 2019-11-07 15:57:47 -08:00
Alexandru Dima
c34e736195 Forward SemanticColoring disposals to the ext host 2019-11-07 16:06:46 +01:00
Johannes Rieken
e5719685cc implement api commands for call hierarchy, #83274 2019-11-07 14:05:50 +01:00
Alex Dima
57995de234 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-06 08:51:39 +01:00
Daniel Imms
e41c71b0d0 Merge branch 'master' into tyriar/63052 2019-11-05 10:32:42 -08:00
Daniel Imms
1d60909d1f Implement Terminal.creationOptions API
Fixes #63052
2019-11-05 10:30:43 -08:00
Daniel Imms
7215e5e9f5 Pass through undefined exit codes 2019-11-05 09:17:57 -08:00
Daniel Imms
2a0d3d0140 Support Terminal.exitStatus API
Fixes #62103
2019-11-05 09:09:39 -08:00
Alexandru Dima
308ff31f95 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-05 09:44:55 +01:00
Matt Bierner
dcecb9eea6 Documenting thoughts on direction for custom editor API
This documents the current thinking on the custom editor api. The current api proposal is not actually implemented yet
2019-11-04 15:11:54 -08:00
Johannes Rieken
31160103a3 migrate proposed API onto new events 2019-11-01 12:05:32 +01:00
Benjamin Pasero
b7b21844e7 api - fold app uri creation into asExternalUri (fix #82884) 2019-10-29 07:18:19 +01:00
Jackson Kearl
69fd68da9f Preserve comment thread collapse state across extension host update messages, fixes https://github.com/microsoft/vscode-pull-request-github/issues/1400 2019-10-24 12:00:53 -07:00
Johannes Rieken
15bcf1a8c5 call hierarchy shows root node, also update API proposal for this, #81753 2019-10-24 20:20:27 +02:00
Johannes Rieken
5d6a46cfb5 Merge branch 'master' into joh/completionOverwrite 2019-10-23 17:21:33 +02:00
Daniel Imms
5db496f7cf Fix strictFunctionTypes in terminal proc
Part of #81574
2019-10-22 09:30:00 -07:00
Johannes Rieken
9f474febfe implement API proposal 2019-10-22 16:48:12 +02:00
Matt Bierner
d6ab43118d Create WebviewExtensionDescription in extHostProtocol 2019-10-17 10:50:34 -07:00
Matt Bierner
721886ce10 Allow registerWebviewEditorProvider to pass in a set of initial webview options
Fixes #82128
2019-10-17 10:50:34 -07:00
Matt Bierner
48195455a1 Remove the setExtension helper
Instead pass over the extension when resolving the extension itself
2019-10-15 11:31:24 -07:00
Joao Moreno
d9e93a7067 Merge branch 'joao/fix-82264' 2019-10-15 13:03:24 +02:00
Daniel Imms
a30e88aca1 Revert "Fix strictFunctionTypes errors in terminal proxy"
This reverts commit 7f5a4a3f5b.
2019-10-13 10:55:54 -07:00
Joao Moreno
4a81920398 Revert "scm: make tree rendering opt-in via proposed API"
This reverts commit afa911d942.
2019-10-11 19:10:27 +02:00
Joao Moreno
afa911d942 scm: make tree rendering opt-in via proposed API
fix #82203
2019-10-10 18:37:38 +02:00
Johannes Rieken
50c2639b86 Merge branch 'joh/strict' 2019-10-07 08:30:19 +02:00
Daniel Imms
7f5a4a3f5b Fix strictFunctionTypes errors in terminal proxy
Part of #81574
2019-10-04 17:39:05 -07:00
Johannes Rieken
c06c223ee9 more strict init work 2019-10-04 11:52:05 +02:00
Matt Bierner
8079ff0001 Rename resolveExternalUri to asExternalUri
#81131
2019-09-30 14:22:47 -07:00
Johannes Rieken
111c29c085 Merge pull request #80895 from mjbvz/use-const-enums-for-suggest-dto
Use const enums for minimized ISuggestDataDto field names
2019-09-30 15:34:48 +02:00
Alexandru Dima
45a92a4937 wip 2019-09-30 15:19:07 +02:00
Matt Bierner
e0762af258 Move webview content state into webviewPanel instead of webviewEditor
Split out from #77131

The current webview editor api is very procedural. This model has some problems when it comes to supporting editing resources, but actually does make a lot of sense for webviews that aren't backed by real file system resources. For example, if you have a webview that edits some document in the cloud, you should not be required to implement a custom file system provider just to enable basic saving.

This change moves the `onWillSave` and `webviewEditorState` properties back onto `WebviewPanel` instead of keeping them specific to `WebviewEditor`. The save implementation does not fully work yet, as the will require #81521
2019-09-26 18:05:37 -07:00
Benjamin Pasero
64eed745f5 💄 move a few services around 2019-09-26 18:37:58 +02:00
Matt Bierner
0506f7f736 Make sure image views (and custom editors) work properly on the web
This fixes an issue where webviews for custom editors did not have any associated extension information, which caused them try reading `file:` uri resources instead of remote uri resources
2019-09-25 16:25:39 -07:00
Alexandru Dima
7e4991aa33 WIP 2019-09-25 17:49:27 +02:00
Matt Bierner
a62b7dabe7 Make resolveExternalUri return just a plain uri instead of a disposable result
For #81131

We had trouble coming up with cases where extensions could actually reliably dispose of the resolved uri
2019-09-23 10:58:21 -07:00
Matt Bierner
a817a588c7 Moving resolve uri logic into openerService
- Add a resolveExternalUri function to the opener service. This service already has to know how to resolve external uris so it makes sense that the function lives there

- Move the tunneling logic for desktop into window.ts

- Make result of resolve disposable
2019-09-20 17:17:42 -07:00
isidor
a9c67d8b82 extHost startDebugging minor polish 2019-09-19 16:08:52 +02:00
Isidor Nikolic
c4a6fc1078 Merge pull request #80673 from dgozman/fix-62419
Allow debug session to share repl with its parent; fixes #62419
2019-09-19 16:05:08 +02:00
Christof Marti
715b6c5792 Add extension id that triggered the activation event 2019-09-19 09:42:17 +02:00
Matt Bierner
27bac598cc Basic implementation of resolveExternalUri 2019-09-18 18:20:26 -07:00
Dmitry Gozman
e4d4b43f35 Allow debug session to share repl with its parent; fixes #62419
Introduced DebugSessionOptions passed to debug.startDebugging which
encapsulated DebugConsoleMode to control this behavior.
2019-09-18 11:45:39 -07:00
Sandeep Somavarapu
7ccfc2dcc5 remove user data api implementation 2019-09-18 12:21:34 +02:00