Commit Graph
133 Commits
Author SHA1 Message Date
Tyler James LeonhardtandGitHub be59ec51ee Add learnMore proposed API to forceNewSession (#206588)
ref https://github.com/microsoft/vscode/issues/206587
2024-03-01 05:02:41 -08:00
Tyler James LeonhardtandGitHub 4e81df7ea9 Tear down the Authentication monolith (#206495)
* Tear down the Authentication monolith

Major changes:
* Turn the usage functions into a proper service `AuthenticationUsageService`
* Pull out the access data stuff into its own service `AuthenticationAccessService`
* Pull out things that make sense as actions `ManageTrustedExtensionsForAccount` `SignOutOfAccount`
* Pull out random registry stuff into a proper authentication contribution
* Pull out everything else that is extension specific into its own class (and eventually it should be in MainThreadAuthentication)
* Have the new `AuthenticationService` return a provider instead of having specific methods for getting the `label` or `supportsMultipleAccounts`

* fix tests

* fix tests
2024-02-29 05:41:11 -08:00
Matt BiernerandGitHub 31fbc3dc94 Remove extra not null assertions (#202201)
* Remove extra not null assertions

With https://github.com/microsoft/TypeScript/pull/56908, TS should better preserve type refinements. To help test this out, I made a quick pass through our code to remove type assertions that are no longer needed

Most of these are not impacted by https://github.com/microsoft/TypeScript/pull/56908 but removing them helps TS test changes like this

Not adding an eslint rule for now as it requires whole program intellisense, which is too slow for commit hooks

* Fix merge
2024-01-30 15:43:09 -08:00
Tyler James LeonhardtandGitHub b33222d206 Allow Embedders to contribute auth providers (#201897)
* Allow Embedders to contribute auth providers

* update integration tests
2024-01-05 11:42:36 -08:00
Tyler James LeonhardtandGitHub eb55c74a90 Allow Core to contribute auth providers (#201741)
* Allow Core to contribute auth providers

This props us up to allow embedders to contribute their own auth providers that override. This is moving in the direction to resolve this one: https://github.com/microsoft/vscode/issues/197389

* handle the change to AuthenticationSessionsChangeEvent to align with vscode API
2024-01-03 13:57:54 -08:00
Tyler James LeonhardtandGitHub 4678919d52 Return the session if the user constented (#195527)
Fixes https://github.com/microsoft/vscode/issues/195286

If the auth provider doesn't support multiple accounts and we have a valid session and the user consented, then use that session.
2023-10-12 21:48:53 -07:00
Tyler James LeonhardtandGitHub 9ceac58405 Proposed API for forceNewSession taking in a session to re-create (#181972)
ref #152399
2023-05-09 17:41:09 -07:00
Tyler James LeonhardtandGitHub 4129a034ed Initial getSessions API (#177036)
* Initial getSessions API

ref https://github.com/microsoft/vscode/issues/152399

* include provider id in key
2023-03-14 10:20:13 -07:00
Benjamin Pasero 8db5e04ab2 dialogs - adopt more confirm method 2023-01-31 08:19:26 +01:00
Tyler James LeonhardtandGitHub af4ea031fb Use the session access flow (#165567)
* Use the session access flow

At some point I accidentally stopped using `requestSessionAccess`. It helps a ton when you have multiple extensions that are requesting the same scopes. This re-uses it.

Also fixed a leaking disposable.

* clean up session preference a bit

* use new api in one more place
2022-11-07 03:41:05 -08:00
Tyler James LeonhardtandGitHub b129227aba move to APPLICATION for all auth usages (#153381)
move to APPLICATION for all auth since auth is really done machine wide. ref #152679
2022-06-27 21:11:25 +00:00
Benjamin PaseroandGitHub e438d4d721 Rename StorageScope.Global to Profile (#152703)
profile rename
2022-06-21 10:16:50 +02:00
Tyler James LeonhardtandGitHub 847629239b add owner and comment to some telemetry events (#148752) 2022-05-05 17:30:51 -04:00
Tyler James LeonhardtandGitHub 6c8d8a2654 Have forceNewSession behave like createIfNone if no sessions are present (#148819)
* Have forceNewSession behave like createIfNone if no sessions are present

* include note in vscode.d.ts about forceNewSesssion behavior
2022-05-05 13:30:14 -07:00
ImCaO 49b661886b Fix spell check errors in translatable strings 2022-04-12 00:03:22 +08:00
Tyler Leonhardt 757b70873e move Auth types to a better location 2022-02-04 16:53:37 -08:00
Alex Dima 6136c815bc Renames 2022-02-04 15:01:44 +01:00
Johannes Rieken 4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Dima e2541e9263 Move extHostCustomers.ts to workbench/services (#141003) 2022-01-31 19:57:21 +01:00
Alex Dima ab3a42aac3 Reduce imports of workbench/api (#141003) 2022-01-31 17:30:04 +01:00
Alex Dima 973684056e Rename modes to languages 2021-12-30 18:52:15 +01:00
Tyler Leonhardt 9ec1ae1d92 silently getting session should return a session (if any) regardless of preference. fixes #137819 2021-11-24 16:40:39 -08:00
John MurrayandGitHub ed3018f431 Capitalize account signout button caption correctly (#137651) (#137652) 2021-11-22 18:25:11 -08:00
Tyler Leonhardt f4e58732b9 clearSessionPreference works again + test. Fixes #137615 2021-11-22 17:14:56 -08:00
Tyler James LeonhardtandGitHub c71e201bed refactored mainthreadauth with silent option and tests (#135503) 2021-10-20 12:17:06 -07:00
Tyler Leonhardt 684fff706a initial unoptimized hasSession API 2021-10-14 13:39:11 -07:00
Tyler Leonhardt 262a3c6a47 add telemetry for provider usage 2021-08-03 17:40:44 -07:00
Tyler Leonhardt c935e2292f rename forceRecreate to forceNewSession and allow it to take in a detail 2021-08-03 16:21:04 -07:00
Tyler Leonhardt 37687f06b6 add proposed forceRecreate option on getSession. Related to #129064 2021-07-20 16:09:36 -07:00
Tyler Leonhardt ba01bbac9c Remove deprecated auth API proposals. Fixes #127144 2021-07-08 10:38:23 -07:00
Tyler Leonhardt 66ecd8f6a8 make state of trusted extensions correct in storage. Fixes #118486 2021-06-11 17:21:37 -07:00
Benjamin Pasero dc4b317192 dialogs - do not require buttons property 2021-06-03 08:49:30 +02:00
Tyler James LeonhardtandGitHub 7f21b1af48 Revert "Allow extensions to create multiple sessions from the same provider (#124640)" (#124705)
This reverts commit a18ea9c9ec.
2021-05-26 10:42:20 -07:00
Tyler James LeonhardtandGitHub a18ea9c9ec Allow extensions to create multiple sessions from the same provider (#124640) 2021-05-25 20:02:19 -07:00
Rachel Macfarlane fde9e2fc15 Add cancel button to manage trusted extensions quickpick, fixes #113347 2021-05-07 09:43:04 -07:00
Sandeep Somavarapu bc62648b05 Revert "Remove authentication provider package.json declaration"
This reverts commit 811dc8d45a.
2021-03-05 14:02:57 +01:00
Rachel Macfarlane 811dc8d45a Remove authentication provider package.json declaration 2021-03-01 14:11:26 -08:00
Rachel Macfarlane 2852916b59 Pass scope directly when signing in to other account, fixes #117510 2021-02-24 13:06:13 -08:00
Rachel Macfarlane 79b14947e7 Polish sign out dialog, fixes #117473 2021-02-23 13:58:59 -08:00
Rachel Macfarlane 6fa58b5a86 Show provider label instead of id in sign in prompt, fixes #117461 2021-02-23 11:47:04 -08:00
Rachel Macfarlane 42e8d3eeb8 Fix select session behavior, fixes #117266 2021-02-22 09:40:16 -08:00
Rachel Macfarlane 52ebf0c7f8 Add 'deny' option to account access prompt 2021-02-18 17:05:58 -08:00
Rachel Macfarlane d131331195 Remove extra info from onDidChangeSessions event 2021-02-18 15:36:28 -08:00
Rachel Macfarlane a5ff0dd6ee Return from getSession earlier when requesting session access 2021-02-17 11:36:43 -08:00
Rachel Macfarlane 14669c2e45 Make scopes parameter optional to getSessions and remove getAllSessions 2021-02-12 09:13:11 -08:00
Rachel Macfarlane eceff53351 Rename login/logout to createSession/removeSession 2021-02-11 16:46:47 -08:00
Rachel Macfarlane e4cf7f46ee Remove account caching from MainThreadAuthenticationProvider 2021-02-11 14:15:36 -08:00
Rachel Macfarlane 650906c369 Pass scopes through to authentication providers 2021-02-11 14:15:36 -08:00
Rachel Macfarlane 9118a3461c Make onDidChangeSessions event for auth providers fire complete session 2021-02-11 10:14:28 -08:00
Rachel Macfarlane a9f803753c Create no accounts menu on demand 2021-02-10 09:53:04 -08:00