Benjamin Pasero and GitHub
6786b8fb9a
untitled - use ref counted lifecycle ( #194371 )
...
* wip
* cleanup
* also use ref in main
* fix one test
* adop `canDispose` for untitled as well
* untitled - ignore dirty on change on revert
2023-11-06 12:58:50 +01:00
Benjamin Pasero and GitHub
642ff50c64
Set more errors we throw to be excluded from telemetry ( fix #187452 ) ( #188650 )
2023-07-24 09:06:26 +02:00
Johannes
43c31079ee
manual fixing of prefer-const violations
2022-06-09 10:19:56 +02:00
Johannes
0656d21d11
auto-fixed prefer-const violation
2022-06-08 17:49:21 +02:00
Johannes Rieken
e8e34889d8
missing throw
2022-03-08 15:33:47 +01:00
Johannes Rieken
8f2a1c1a59
💄 async-await and others
2022-02-22 15:24:33 +01:00
Johannes Rieken
6f1eadf42a
don't have _modelTrackers has map and inn parallel _modelIsSynced as set, https://github.com/microsoft/vscode/issues/143609#issuecomment-1047812721
2022-02-22 15:05:36 +01:00
Johannes Rieken
e240ada98f
fix https://github.com/microsoft/vscode/issues/142727
2022-02-22 13:21:01 +01:00
Benjamin Pasero and GitHub
0e8fcebfbc
files - adopt fileService.stat method in more places ( #143491 )
...
* types
* adopt fileservice.stat
2022-02-20 13:14:11 +01:00
Johannes Rieken
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391
2022-02-02 14:35:33 +01:00
Alex Dima
e2541e9263
Move extHostCustomers.ts to workbench/services ( #141003 )
2022-01-31 19:57:21 +01:00
Alex Dima
e5d893eb40
Move languageSelector out of /languages/ ( #141174 )
2022-01-21 23:41:54 +01:00
Benjamin Pasero and GitHub
4cd3294855
rename mode => language in many places ( #139920 )
2021-12-30 12:40:30 +01:00
Alex Dima
c8e2fd7bae
Renames
2021-12-29 00:37:35 +01:00
Alex Dima
365a3c23be
Rename mode to language
2021-12-28 10:51:35 +01:00
Sandeep Somavarapu
4ed0329e9c
#135935 move IUriIdentityService to platform
2021-11-03 12:11:00 +01:00
Alex Dima
11862795ea
Remove LanguageIdentifier and ensure tests dispose instantiated LanguagesRegistry objects
2021-10-18 10:29:16 +02:00
Johannes Rieken
112a32e614
Add another limit to when we auto-dispose document references that have been created by extensions. In addition to a timeout and overall weight, we also check the number of document references we have and cap them to 60, fixes https://github.com/microsoft/vscode/issues/133325
2021-10-11 12:42:32 +02:00
Johannes Rieken
8f8634b774
💄 don't use object as map
2021-04-30 15:13:07 +02:00
Johannes Rieken
1f913a81b1
Revert "better fix for https://github.com/microsoft/vscode/issues/119943 "
...
This reverts commit 0877dc2131
2021-04-28 16:17:37 +02:00
Johannes Rieken
134f551f21
Revert "remove unused code after changes for https://github.com/microsoft/vscode/issues/119943 "
...
This reverts commit 05658fe91e
2021-04-28 16:17:37 +02:00
Johannes Rieken
05658fe91e
remove unused code after changes for https://github.com/microsoft/vscode/issues/119943
2021-04-28 15:46:20 +02:00
Johannes Rieken
0877dc2131
better fix for https://github.com/microsoft/vscode/issues/119943
2021-04-28 15:39:48 +02:00
Johannes Rieken
d0fceb64b4
fix disposal of extension-triggered document references when file is deleted, https://github.com/microsoft/vscode/issues/119943
2021-04-28 14:59:03 +02:00
Matt Bierner and GitHub
e1f0f8f513
Add override keyword in codebase ( #120755 )
...
For #120675
This uses a script to add the override keyword to places that need it in the codebase
Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Johannes Rieken
9cc276648e
remove onDidChangeCellLanguage-event in favor of the existing document closed/opened event sequence
2021-03-09 15:14:30 +01:00
Johannes Rieken
a246f643ee
debt, copy-paste police
2021-02-18 17:27:32 +01:00
Benjamin Pasero
3b99352509
debt - inline remoteAuthority into workbench environment service
2020-10-07 15:57:28 +02:00
Benjamin Pasero
6e022766d1
debt - adopt defaultUriScheme over hardcoded vscode-remote in toLocalResource
2020-09-10 18:03:51 +02:00
Alex Dima
802572340b
Fixes #101956
2020-07-09 12:35:58 +02:00
e3033faeee
File operation events support multiple resources ( #98988 )
...
* refactor: use array of resources
* refactor: use an array of uricomponentspair
* feat: move many resources
* refactor: rename data to files
* feat: use array of files for copy
* refactor: use move with multiple resources
* refactor: use move method with array of files
* refactor: rename data to files
* feat: moveOrCopy array of resources on paste
* refactor: use concise loop syntax
* test: assert number of events
* refactor: rename uricomponentspair
* support multiple files on WorkingCopyFileEvent
* feat: support multiple resources
onWillRunWorkingCopyFIleOperation onDidRunWorkingCopyFileOperation
* refactor: make source optional for consistency
* refactor: support resources for delete
* test: isolate tests
* fix: iterate over resources
* feat: support operations on delete
* feat: adopt deleting multiple resources
* fix: typing and sequential flow of copyservice
* fix: typing and naming
* fix: typing and naming
* fix: use different message for multiple overwrites
* refactor: naming consistency
* fix: use array resources
* fix: message for multiple overwrites
* fix format
* clean up working copy file service
* refactor multiple overwrites message helper
* use openeditors to bulk open
* split drop copy and move
* add returns
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com >
2020-06-24 10:32:55 +02:00
Benjamin Pasero
a131d1498a
uri - adopt uri identity for main thread documents when reacting to
2020-06-01 10:46:05 +02:00
Johannes Rieken
b0d056202b
Use canonical uri for openTextDocument api, #93368
2020-05-29 18:16:31 +02:00
Benjamin Pasero and GitHub
a23d4daefa
Dangling text file models of deleted files hanging around in memory ( #98154 )
...
* Dangling text file models of deleted files hanging around in memory (fix #98057 )
* address feedback
2020-05-26 16:29:12 +02:00
Benjamin Pasero
d8251943cc
untitled - share save/saveas logic in one place
2020-01-26 09:26:13 +01:00
Benjamin Pasero
cdc2469931
untitled - rewrite creation logic
2020-01-17 11:33:13 +01:00
Benjamin Pasero
664836ec0e
debt - loadOrCreate => resolve
2020-01-16 15:39:09 +01:00
Benjamin Pasero
70f381a7b9
untitled - bring back loadOrCreate()
2020-01-16 13:11:15 +01:00
Benjamin Pasero
41eabcfcd6
text files - rename models => files
2020-01-16 12:47:46 +01:00
Benjamin Pasero
3d9d1f9f2a
text files - allow to work with untitled from text file service directly
2020-01-16 12:45:13 +01:00
Benjamin Pasero
2a3dc1edac
fix tests
2020-01-13 16:59:08 +01:00
Benjamin Pasero
76c72ffc94
telemetry - restore back load/save reason for files
2020-01-13 16:01:30 +01:00
Benjamin Pasero
ad41028d8f
debt - drop untyped events in favor of typed (text files)
2020-01-13 15:49:21 +01:00
Benjamin Pasero
238617a847
debt - drop TextFileModelChangeEvent
2020-01-13 13:02:50 +01:00
Benjamin Pasero
4f6af32f43
untitled - merge createOrGet and loadOrCreate into one
2020-01-09 10:26:04 +01:00
Benjamin Pasero
da5f408834
workbench editor model: getResource => resource
2019-11-12 17:04:54 +01:00
Benjamin Pasero
87064db103
debt - untitled editor => untitled text editor
2019-11-06 12:44:59 +01:00
Matt Bierner
7ed88bd70c
Use set to track synced values instead of object literal
2019-07-15 11:47:29 -07:00
Matt Bierner
ae2cc878f8
Using DisposableStore in mainThread class
...
#74250
2019-07-02 16:37:35 -07:00
Johannes Rieken
078da2bca6
This partially reverts "extends Disposable" changes
2019-06-06 16:01:15 +02:00
Benjamin PaseroandGitHub
Johannes
Alex Dima
Benjamin PaseroandGitHub
Sandeep Somavarapu
Matt BiernerandGitHub
