Commit Graph

5928 Commits

Author SHA1 Message Date
João Moreno
636dbcff55 Revert "cli: fix error starting remote tunnels (#185701)" (#185731)
This reverts commit ffe64dab3c.
2023-06-21 09:30:30 +02:00
Connor Peet
2138622b04 build: add watch/compile tasks for CLI (#182344)
* build: add watch/compile tasks for CLI

I spent time this morning working on the 'developer experience' of the
CLI in vscode, mainly getting the CLI to cross-compile chasing our
initial idea of having it auto-build in a devcontainer.

After some effort and disabling tunnels connections (to avoid having to
pull in OpenSSL which is a huge pain to cross compile), I was able to
get it to cross-compile from Linux to Windows, using the mingw linker.
I could probably figure out how to get macOS working as well with more
effort. However, I'm not a big fan of this, effectively it's one more
'platform' of build we need to support and test.

I think a better approach is downloading the latest compiled CLI from
the update server instead, as needed. That's what this PR does. It just
places the CLI where it _would_ normally get compiled to by cargo; so
far we don't need to do anything special outside of that.
A notice is shown to users if this fallback happens.

* update from review
2023-06-20 14:34:11 -07:00
Connor Peet
ffe64dab3c cli: fix error starting remote tunnels (#185701)
* untested wip

* cli: fix error starting remote tunnels

Fixes #185585

Output was prefixed which prevented the lines from being split to detect the tunnel status.
2023-06-20 14:30:07 -07:00
Robo
4dac9b530d chore: bump electron@22.3.13 (#185687)
* chore: bump electron@22.3.13

* chore: bump distro
2023-06-20 18:55:16 +02:00
isidor
6af591662a remove workbench/contrib/experiments 2023-06-20 14:36:56 +02:00
Henning Dieterichs
085399feff Merge pull request #185592 from microsoft/hediet/b/horizontal-ladybug
Diff Editor v2 Improvements
2023-06-19 18:53:59 +02:00
Henning Dieterichs
60b19b3dd8 Unchanged collapsed code improvements 2023-06-19 17:25:27 +02:00
Robo
4df3657b4e chore: add checksum for electron assets (#185568)
* chore: add checksum for electron assets

* chore: bump distro

* chore: add pdb checksums
2023-06-19 23:46:41 +09:00
Henning Dieterichs
b975405819 Diff Editor v2: Iterates on collapsed unchanged code feature. (#185499) 2023-06-19 12:41:17 +02:00
Robo
8fb5ea0142 feat: use custom tag instead of custom version for MS electron releases (#181309)
* feat: use custom tag instead of custom version for MS electron releases

* chore: bump @vscode/gulp-electron

* chore: move build id to .yarnrc

* chore: rename enableUNCAccessChecks => restrictUNCAccess

* chore: update electron@22.3.11

* chore: add build info to about dialog

* chore: simplify helper function

* chore: remove unused node.js checksums

* chore: bump nodejs internal version

* chore: bump distro

* fix: revert changes to sign.ts

* chore: bump distro
2023-06-17 03:03:35 +02:00
Johannes Rieken
72e2af69c9 joh/high loon (#185337)
* allow session creation to be cancelled

* define background colors, make sure to reshow after session is ready, reset selection style on hide
2023-06-16 16:45:44 +02:00
Benjamin Pasero
518a183762 eng - add build version of node.js to .yarnrc (#185302)
* eng - add build version of node.js to `.yarnrc`

* 🆙 distro
2023-06-16 09:10:24 +02:00
Matt Bierner
aa82bd59b2 Limit worker pool size (#185164)
Fixes #185079

Should fix OOM issues on build machines
2023-06-14 23:57:22 +02:00
Benjamin Pasero
8afb685c9b eng - add checksum validation support to nodejs and extensions (#184877)
* eng - add `checksum` validation support to `remote`

* eng - wire in more `checksum` support

* eng - renames for remote fetching

* eng - renames for remote fetching

* eng - disable verbose

* eng - always fetch verbose in CI

* eng - 💄

* eng - add checksums for node

* eng - report checksum matches

* eng - fix build

* eng - warn when not being able to check sum

* eng - support checksums for built in extensions

* eng - clear todo

* eng - add nodejs metadata to product.json

* 🆙 version

* 🆙 distro

* update distro

* eng - switch to checksum file

* cleanup alpine

* fix alpine

* fix bug

* eng - fetch all from remote

* eng - 💄

* eng - print checksums

* eng - fix missing import

* 🆙 distro

* undo version change
2023-06-14 16:57:06 +02:00
Benjamin Pasero
4b939d0a0e unc - fix path traversal bypass (#185048) 2023-06-13 19:56:46 +02:00
Matt Bierner
debcf16fcd Mangle exported symbols (#182935)
* Mangle exported functions

For #180461

This prototype tries to mangle exported functions, saving a further 440kb from the bundle size

* Fix missing call

* Also try mangling top level exported consts too

* Fixing errors

* Don't run on build files

* Skip a few more manglings and revert change to namespace

* Skip a few more monaco files

* Also mangle consts that shadow types

This increases savings up to 3325

* Also mangle exported classes

* Skip mangling more localization functions for now

* Opt out pfs

* Update build script

* Run find locations task in parallel

This should speed up compile

* Cleanup before close

* Limit workers to avoid hitting memory limit

* Limit pool size

* Skip one more mangling

* Exclude entrypoints from mangling

* Try to fix web build and clean up code

* Exempt a few more projects

* Exempt another file

* Also exempt html

* Skip mangling ext entrypoints

* Use prefix that can't be confused with rpc calls

* Fix max call stack error

* Switch prefixes

* Don't mangle ambient declarations

* Use correct way of checking modifier flags

* Workaround getCombinedModifierFlags not doing what I'd expect

Maybe needs the checker to be enabled too? Just check parent chain instead for now

* Clean up code and add logic showing how enum mangling could work

* Remove a few more skipMangles

Use entrypoints instead

* Fix entrypoint name
2023-06-13 08:18:05 +02:00
Raymond Zhao
13e7d80fcd Bump windows-process-tree (#184759)
Fixes https://github.com/microsoft/vscode/issues/179697
2023-06-12 11:36:56 -07:00
Robo
b4dd4d51fa ci: switch to bionic agents for arm64 and armhf clients (#184906)
* ci: switch to bionic agents for arm64 and armhf clients

* ci: invalidate cache

* ci: fix docker client installation

* chore: update debian dependencies

* chore: update rpm dependencies
2023-06-13 00:50:36 +09:00
Sandeep Somavarapu
46041c9f0e Implement troubleshoot issue (#184901)
* implement troubleshoot issue action

* move issue troubleshooting to a service

* feedback

* fix stable check
2023-06-12 13:37:50 +02:00
Raymond Zhao
d81ca6dfca Bump windows-registry to 1.1.0 (#184741) 2023-06-09 13:02:58 -07:00
Raymond Zhao
06ae4b61c2 Bump windows-mutex to 0.4.4 (#184366)
Also adds OS-specific .moduleignore files
2023-06-09 09:40:10 -07:00
Benjamin Pasero
eac16e9b63 eng - make fetchWithRetry more robust (#184716) 2023-06-09 14:05:38 +02:00
Connor Peet
49535d6a04 build: fix missing param for build (#184660) 2023-06-09 01:10:08 +02:00
Aiday Marlen Kyzy
7dafe5df1d renaming the CSS variable names and the labels from interactive editor to inline chat 2023-06-08 14:41:41 +02:00
Ladislau Szomoru
cad3a1c656 Engineering - skip property mangling in PR builds (#184584) 2023-06-08 12:42:40 +02:00
Johannes Rieken
d8dcdb924a Merge pull request #184575 from microsoft/joh/protective-cicada
joh/protective cicada
2023-06-08 12:15:04 +02:00
Connor Peet
e686621e2e cli: avoid running prepare a second time in ci (#184558) 2023-06-08 02:22:44 +02:00
Connor Peet
9de813729c build: install clippy when building cli in ci (#184554) 2023-06-07 16:40:30 -07:00
Connor Peet
43742d891d Run a lint build of the CLI in CI (#184545)
* cli: adopt sccache for speedier cli compilations

* only cache common linux x64 build

* instead, only dev compile/clippy lint in ci
2023-06-07 15:48:55 -07:00
Johannes
978bb08619 add extensions-ci-pr task which does a full build without mangling 2023-06-07 16:36:02 +02:00
Aiday Marlen Kyzy
c529638000 renaming the content inside of inlineChat folder from IE to IC 2023-06-07 16:02:34 +02:00
Johannes
ac7789cbab add core-ci-pr task which does a full build without mangling 2023-06-07 15:51:48 +02:00
Benjamin Pasero
e615a31faf eng - increase remote download retries (#184431) 2023-06-06 19:22:56 +02:00
Aaron Munger
693604f7fd Merge branch 'main' into aamunger/testRenderer 2023-06-06 09:21:12 -07:00
Johannes Rieken
f70686c39e chore - rename interactiveEditor to inlineChat (#184422) 2023-06-06 16:34:55 +02:00
Aaron Munger
5c7b2b89fe add project to build, add integration tests into shell script 2023-06-05 14:19:51 -07:00
Henning Dieterichs
aa88e727da Implements initial version of moved code detection. (#184336)
* Implements initial version of moved code detection.

* Fixes monaco.d.ts

* Fixes tests.
2023-06-05 08:50:55 -07:00
Johannes
946cdaa03c stub out cropped/expanded as CSS variables 2023-06-05 14:58:04 +02:00
Ladislau Szomoru
15dc0b5af3 Engineering - fix CLI build for Alpine ARM64 (#184309)
* Add task to install yarn

* Move task

* Add condition
2023-06-05 12:05:51 +02:00
Connor Peet
eb44b5ef6c build: don't apply cli 'patches' for merge check (#184210)
* build: don't apply cli 'patches' for merge check

This also needed modules installed. But with the new toml patches, the 'merge' will never fail outright, so there's no need to do a separate merge check for it imo

* reduce duplication in pipelines, cache node_modules
2023-06-02 22:29:48 +02:00
Connor Peet
be433ac136 build: install packages for distro mixin (#184207) 2023-06-02 21:44:18 +02:00
Connor Peet
42015fe01c build: support structured toml patches to reduce build breakage (#184201)
Currently the Cargo.toml patches are git patches, but these can break
easily when surrounding lines are changed. Instead this lets us make
"Cargo.patch.toml" which gets a structured merge.
2023-06-02 12:09:16 -07:00
Connor Peet
ccc5e48e92 fix: breakpoints in extension subdirs on windows not working (#184195)
It did not normalize to forward slashes, so the empty sourcemap was
created with a source called `foo\\bar.js`. Then the build process was
adding a new source `foo/bar.js` since it didn't see it already in the
sourcemap, but `foo\\bar.js` was later normalized. This normalized
version came first in the mapping, but didn't have any mapped locations,
so breakpoints never got set.
2023-06-02 20:15:04 +02:00
Alex Dima
1331522372 Avoid using types defined in @types/trusted-types 2023-06-02 12:32:46 +02:00
Robo
0c1e34fa4e chore: update electron@22.5.5 (#184115) 2023-06-01 21:38:57 -07:00
Alexandru Dima
828118d55e Allow embedders to intercept trustedTypes.createPolicy calls (#184093) 2023-06-01 15:20:10 -07:00
Martin Aeschlimann
3f5def1cdc Add logging to node download (#184070)
Add logging to node download. For #182951
2023-06-01 16:42:36 +02:00
Connor Peet
78643b05d5 cli: bump to openssl 1.1.1u (#183828) 2023-05-30 20:44:56 +02:00
Martin Aeschlimann
c2a9a86afa Delete --compatibility=1.63 code from the server (#183738) 2023-05-29 15:24:14 -07:00
Robo
c26003f37a chore: update electron@22.5.4 (#183716) 2023-05-29 16:09:35 +02:00