Commit Graph

29 Commits

Author SHA1 Message Date
Matt Bierner
1b70625f8c Use import type when importing vscode under src
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
2020-01-10 14:25:21 -08:00
Jackson Kearl
69fd68da9f Preserve comment thread collapse state across extension host update messages, fixes https://github.com/microsoft/vscode-pull-request-github/issues/1400 2019-10-24 12:00:53 -07:00
Matt Bierner
029009eafd Marking most private emitters as readonly
Emitters should generally not be reassigned as their corresponding event would also be lost. Marking these as readonly just to enforce this
2019-09-23 17:31:18 -07:00
Rachel Macfarlane
8efcc47e18 strictPropertyInitialization, #78168 2019-08-05 09:05:30 -07:00
Peng Lyu
97ce6669fa toggle reaction should work. 2019-07-18 15:38:44 -07:00
Peng Lyu
f1bad37012 Remove Comment Id 2019-07-18 15:34:05 -07:00
Rachel Macfarlane
877235c625 Remove old proposed commenting API 2019-07-10 11:11:14 -07:00
Johannes Rieken
c8843e3b0d final touch at heap service removal, #74846 2019-06-19 10:58:24 +02:00
Peng Lyu
8ef603062f #74846. no CommandsConverter#toInternal 2019-06-14 13:03:41 -07:00
Peng Lyu
63672ffaa7 Merge pull request #74930 from microsoft/rebornix/commentreactions
Comment Reaction API
2019-06-10 10:36:21 -07:00
Peng Lyu
cae0668a0e reactions handler 2019-06-05 21:08:41 -07:00
Rachel Macfarlane
83ef31e6a2 Correctly set extensionId on comment threads 2019-06-04 11:50:47 -07:00
Peng Lyu
c042dabe2b Fix #74641. Update viewzone afterline when position changes. 2019-05-31 10:27:56 -07:00
Peng Lyu
346da6b01a dispose empty comment thread when collapse. 2019-05-23 16:37:42 -07:00
Peng Lyu
e26568b586 Add contextValue support 2019-05-21 16:59:34 -07:00
Peng Lyu
b8c1a34885 thread id is still updatable 2019-05-21 15:08:47 -07:00
Peng Lyu
7554ac4387 Edit comment 2019-05-17 18:16:14 -07:00
Rachel Macfarlane
925426e8b0 Remove activeCommentThread from extHost comments, set context keys on simple comment editor 2019-05-17 16:52:36 -07:00
Peng Lyu
e6152cc29f icons for menu bar 2019-05-17 16:34:47 -07:00
Peng Lyu
4186bc0a44 menu items 2019-05-17 11:49:00 -07:00
Peng Lyu
0683efcf4f Deprecate commands for static contribution later, fixes #73333 2019-05-06 14:17:44 -07:00
Peng Lyu
da3c97f366 Rename username to author name. (#73137)
* Rename user to author for Comment.

* Make Comment interface

* Fix #73170. Introduce CommentAuthorInformation

* Fix #73145. Update range properly.
2019-05-03 18:29:48 -07:00
Peng Lyu
072e9a35ee Comments API Finalization (#73010)
* Comments API Finalization
2019-04-30 14:59:59 -07:00
Peng Lyu
253809c186 Legacy api should still work. 2019-04-28 16:35:01 -07:00
Peng Lyu
6a4805546a Bring back empty comment thread factory. 2019-04-28 14:02:23 -07:00
Peng Lyu
9435d7cc38 support deprecated commentId. 2019-04-28 13:24:58 -07:00
Peng Lyu
2884d2239b Add active comment thread. 2019-04-28 12:30:29 -07:00
Peng Lyu
3d814eb92d Comment Id. 2019-04-28 11:57:37 -07:00
Johannes Rieken
c0821aa5e9 move extHost-files to common 2019-04-10 10:26:52 +02:00