Commit Graph

957 Commits

Author SHA1 Message Date
Alex Ross
1236c13709 Ports attributes API updates (#182617)
* Ports attributes API updates
Part of #115616

* Remove port number from attributes API
2023-05-16 13:01:14 +02:00
Michael Blout
3aec07b38a fix: debug focus, remove 'kind' discriminators 63943 (#181244)
* fix: review comments, remove 'kind' discrims, use instanceof

* fix: tweak the isXXXX checks, add some prop typeof checks

* fix: review, remove isX duck type fncs, and construct object
2023-05-15 18:14:05 -07:00
Rob Lourens
2156969dcf Rename files 2023-05-15 15:54:11 -07:00
Rob Lourens
d72649d458 Rename some classes and methods from "interactive session" to "chat" 2023-05-15 15:38:59 -07:00
Joyce Er
2c5dcb3b81 Allow Continue On between repos with HTTPS and SSH remotes (#182352)
* Deduplicate HTTPS and SSH remote URLs

* Improve doc
2023-05-15 11:37:38 -07:00
Connor Peet
e47a286153 resolvers: add appQuality and appCommit (#182532)
Currently remote extensions use a hack to read the product.json, but
this can't be done on web. Instead expose proper API to get the
appQuality and appCommit.
2023-05-15 11:18:57 -07:00
Connor Peet
364b84e3ec Merge remote-tracking branch 'origin/main' into connor4312/inline-remote-resolver 2023-05-11 09:55:21 -07:00
Alex Dima
dde5a4f356 Add dedicated protocol for managed sockets (mainThreadManagedSockets and extHostManagedSockets) 2023-05-11 11:24:24 +02:00
Tyler James Leonhardt
a9c2b682ed Make proposed API clearer (#182093)
* Add missing typedoc

* Also update docs for proposed

* rename getSessions to authGetSessions
2023-05-10 22:27:26 +00:00
Connor Peet
2bc8da8327 Merge remote-tracking branch 'origin/main' into connor4312/inline-remote-resolver 2023-05-09 11:48:20 -07:00
Rob Lourens
60fe2d5970 💄 (#181647)
Clean up from hacking session
2023-05-05 18:35:11 +02:00
Rob Lourens
aebaec6caf Add API for custom slash command providers (#181604)
Likely temporary API for experimentation
2023-05-05 10:00:21 +02:00
Benjamin Pasero
1ed110b6be Return resulting URI from commands that save the active editor (fix #178713) (#179091)
* Return resulting `URI` from commands that save the active editor (fix #178713)

* 💄

* address feedback

* change to real proposed API

* cleanup
2023-04-20 18:00:12 +02:00
Tyler James Leonhardt
0724039270 Initial IssueUriRequestHandler proposed API (#180363) 2023-04-19 23:18:44 +02:00
Connor Peet
f5427eed53 remote: first cut at 'inline' remote resolvers
For web, it seems the most feasible direction for resolvers as we make
existing remote extensions 'web enabled' is to allow them to run in the
extension host. However, in no case will there just be a simple
websocket we can connect to ordinarily.

This PR implements a first cut at 'inline' resolvers where messaging is
done in the extension host. I have not yet tested them on web, where I
think some more wiring is needed to mirror desktop. Also, resolution of
URLs is not in yet. I think for this we'd want to do some service-worker
-based 'loopback' approach to run requests inline in the remote
connection, similar to what I did for tunnels...

Resolvers are not yet run in a dedicated extension host, but I think
that should happen, at least on web where resolvers
will always(?) be 'inline'.

Most of the actual changes are genericizing places where we specified
the "host" and "port" previously into an enum. Additionally, instead of
having a single ISocketFactory, there's now a collection of them, which
the extension host manager registers into when a managed resolution
happens.
2023-04-18 15:54:20 -07:00
Johannes Rieken
949c8073e2 ensure proposed API is checked for (#180194)
fy  @roblourens and @mblout
2023-04-18 10:34:13 +02:00
Michael Blout
2de3b04eaf Add debug API for call stack selection changes (63943) (#179132)
* feat: Initial pass at Debug Focus, listener for thread or stack frame
selection (#63943)

Add debug.onDidChangeDebugFocus. May provide ids for session, thread,
and stackFrame, as appropriate.

Fixes: #63943 api should provide thread/stack frame id (paraphrasing)

* chore: small comment tweaks in proposal

* fix: bad copy/paste in proposed. moved types out of 'debug' namespace

* fix: separate 'debugFocus' into thread and stackFrame specific
listeners, and create separate contexts for each

* fix: Revert prev change, switch to single api with union type

This reverts commit c308bc3a90.

* fix: rename accessor from 'focus' to 'stackFrameFocus'

* fix: review comments; remove unused type, imrpove comments

* fixL review comments, type change:  sessionID property cannot be undefined

* Remove comments

---------

Co-authored-by: Rob Lourens <roblourens@gmail.com>
2023-04-17 18:42:53 +00:00
Ladislau Szomoru
218b8bd8da SCM - Add document property to expose the text document (#171504) 2023-04-14 13:55:14 +02:00
Matt Bierner
e9262678fa Add drop feedback UX (#179434)
For #179430

Adds two new UX components:

- An inline progress icon shown when a drop operation takes over 500ms. This replaces the notification. You can click on it to cancel the drop

- Post drop, a drop feedback icon that lets you drop the file in a different way. This lets you drop the file as plain text for instance instead of as a markdown link
2023-04-11 13:48:24 -07:00
Tyler James Leonhardt
a0361ed685 introduce a SemanticSimilarity provider model (#179640)
* introduce a SemanticSimilarity provider model

* have raceCancellablePromises also cancel if it rejects

* remove extensionId for now

* remove unused code
2023-04-10 16:07:07 -07:00
Peng Lyu
f7d1b7c8fb Finalize onWillSaveNotebookDocument (#179188) 2023-04-04 19:01:53 -07:00
Johannes Rieken
ab6087f090 update format ranges API proposal based on feedback (#179166)
https://github.com/microsoft/vscode/issues/158776
2023-04-04 19:19:15 +02:00
Johannes
99d65cd47c remove generic type, move API additions to separate proposals file, enforce proposal 2023-03-30 16:50:58 +02:00
Johannes Rieken
a47c78516c Merge branch 'main' into multirange-formatting 2023-03-30 16:33:11 +02:00
Peng Lyu
666e417297 Re #157844. Update for onWillSaveNotebookDocument. (#178602) 2023-03-29 10:56:52 -07:00
Hermann Loose
de3b0db8e8 Allow individual comments to be marked as draft (#173305)
* Allow individual comments to be marked as draft

This is a proposal for #171166.

* Remove `hasDraftComments` from `CommentThread`

* Rename `CommentVisibility` to `CommentState`

* Rename `CommentVisibility` to `CommentState`

* Add api proposal check

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
2023-03-28 19:18:22 +02:00
Johannes Rieken
d02cb53f06 add InteractiveEditorResponseFeedbackKind as dedicated enum (#178043) 2023-03-22 19:28:29 +01:00
Johannes Rieken
2f1f07ec2b make feedback explicit and stateful (#178007) 2023-03-22 14:30:07 +01:00
Peng Lyu
c048e13440 Adopt async emitter for notebookOnWillSave (#177686) 2023-03-20 10:31:14 -07:00
Rob Lourens
7f040c2c37 Add telemetry for manual copying from interactive session codeblocks (#177513) 2023-03-17 13:23:28 -07:00
Peng Lyu
1a2324213c 📓 OnWillSaveNotebookDocument (#177421)
* 📓 OnWillSaveNotebookDocument

* Proposed api check
2023-03-17 09:00:59 -07:00
Johannes
ac22dad6fa cleanup, support commands, render richer message 2023-03-16 12:36:29 +01:00
Rob Lourens
215351a4cf Add sendInteractiveRequestToProvider API (#177155) 2023-03-14 21:09:25 -07:00
Tyler James Leonhardt
4129a034ed Initial getSessions API (#177036)
* Initial getSessions API

ref https://github.com/microsoft/vscode/issues/152399

* include provider id in key
2023-03-14 10:20:13 -07:00
Rob Lourens
cd1d31179d Add event fired when the user performs actions on interactive session responses (#176829)
* Add an id to responses that comes from the provider

* Add event fired when the user performs actions on interactive session responses

* Only show user action buttons when the provider has added a response ID
2023-03-10 21:48:37 -08:00
Logan Ramos
ca1186f3ec Fix missing common props for extensions (#176445)
* Fix missing common props for extensions

* Add test for options
2023-03-07 16:23:12 -08:00
Johannes
ef3336cd65 interactive editor and API sketch 2023-03-02 09:27:13 +01:00
Rob Lourens
825e84e144 Implement interactive session provider api (#175810)
Implement interactive session provider
2023-03-01 23:47:18 +01:00
Alex Dima
3d1487099b Add ExtensionIdentifierSet and ExtensionIdentifierMap 2023-02-26 00:13:58 +01:00
Cristopher Claeys
636dd226c6 Address PR comments 2023-02-16 19:43:29 +01:00
Cristopher Claeys
17f5d8b168 Add support for multiRange formatting 2023-02-16 19:43:29 +01:00
Tyler James Leonhardt
f861acbee1 Enable a tooltip in quick pick (#174417)
* hover in quickpick

* refactoring

* fix tests

* remove HTMLElement from API for now

* API proposal
2023-02-15 17:35:09 +01:00
Alex Ross
89c4f61de2 Alexr00/showLocalAPI (#173798)
* Propose "allowLocal" open dialog option API
Part of #131138

* Update comment

* allowUIResources API proposal
Part of #131138

* Fix scheme ordering and update doc comment
2023-02-09 09:53:24 +01:00
Henning Dieterichs
c3bf0fb83c Fixes #172384 2023-01-30 14:35:39 +01:00
Logan Ramos
0ba16b8326 Finalize telemetry proposal (#171858) 2023-01-23 09:44:04 +01:00
Johannes Rieken
5dbb41f91d validate telemetry sender when creating a logger (#171842)
fixes https://github.com/microsoft/vscode/issues/170073
2023-01-20 17:58:07 +01:00
Alex Ross
6894f821dc Add uri transformer to quick diff provider (#171614) 2023-01-18 15:06:28 +01:00
Alex Ross
920540cba4 Quick diff provider proposal updates (#171606)
* return type

* Add document selector
2023-01-18 13:01:40 +01:00
Joyce Er
30f439066e API: emit event with waitUntil when an edit session identifier will be requested (#171210)
* Support syncing with remote before Continue On

* Use `AsyncEmitter` util to implement `waitUntil`
2023-01-13 19:24:56 +01:00
Alex Ross
04f0fb46ff Separate quick diff API from SCM (#170544)
* Separate quick diff API from SCM
Part 1: split up the API.
upcoming in part 2: In editor UX for multiple quick diffs.
Fixes #169012

* Respond to review feedback

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2023-01-12 11:19:41 +01:00