Commit Graph

271 Commits

Author SHA1 Message Date
Matt Bierner 087629786a Mark private service properties declarated in ctors as readonly 2019-01-04 12:03:24 -08:00
Matt Bierner b4964bcf35 Replace some common index based for loops with for-of loops
Replaces many loops of the form:

```js
for (let i = 0; i < elements.length; ++i) {
    const i = elements[i];
   ...
}
```

with:

```js
for (const element of elements) {
    ...
}
```

Mix of a horrible regex based find/replace and manual touch ups
2019-01-03 19:11:18 -08:00
Rob Lourens ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Chris Ganga 63455c0d89 enable strict null check for windowsFinder (#65551) 2018-12-21 13:50:00 +01:00
Matt Bierner b7b1088bde Strict null check cliProcessMain 2018-12-17 14:46:59 -08:00
Johannes Rieken 653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Benjamin Pasero 227fd6634b fix #64597 2018-12-12 08:00:50 +01:00
Joao Moreno de63daf348 remove TPromise.wrapError
related to #63897
2018-12-10 11:33:41 +01:00
Sandeep Somavarapu cbb9fa7385 Fix #59481 2018-12-03 15:51:30 +01:00
Sandeep Somavarapu 7b20b40161 #14034 Support installing specific version 2018-11-27 17:06:55 +01:00
Sandeep Somavarapu f6221e6522 Check for ui extension while installing vsix 2018-11-19 17:31:49 +01:00
Joao Moreno f4c2b2021d debt: remove TPromise from cli
related to #62716
2018-11-15 17:58:58 +01:00
Johannes Rieken b35d879f76 update v8 profiler package 2018-11-12 17:37:10 +01:00
Matt Bierner 5acd78e288 Strict null checks 2018-11-08 18:15:43 -08:00
Matt Bierner cb05d8fdf3 Strict null checks 2018-11-08 18:04:56 -08:00
Rob Lourens 284864239f Strict null check paths.ts 2018-11-06 14:27:48 -08:00
Matt Bierner fec1775aa5 Strict null checks 2018-11-05 13:39:33 -08:00
Johannes Rieken 276aeea254 make delayed service instantiation opt-in #61917 2018-10-29 12:07:04 +01:00
Matt Bierner 8df9f241e6 Strict null checks 2018-10-26 17:36:25 -07:00
Benjamin Pasero 4252e67b35 fix one part of #60192 2018-10-26 11:52:44 +02:00
Matt Bierner 0318e90c93 Add null type annotations for the common x: T = null pattern
In these cases, the programmer has explicitly indicated that the type should be nullable
2018-10-11 14:13:20 -07:00
Matt Bierner 428eac303b Adding a few more files to strict null checks 2018-10-11 08:48:59 -07:00
Johannes Rieken b65d113c0a prefix names with prof-, #59505 2018-10-08 10:56:42 +02:00
Benjamin Pasero fc251d651d tpromise => promise (for #53526) 2018-10-04 07:54:47 +02:00
Matt Bierner be38e56996 Remove duplicate blank lines at the start of some files 2018-10-02 16:28:19 -07:00
Matt Bierner d4edb9abcc Remove use strict directives in main VS Code src (part 3)
We compile using the alwaysStrict flag so these directives are not needed.

This part removes most of the remaining use strict directives that were not caught by part 1 and 2
2018-10-02 16:14:11 -07:00
Matt Bierner c63c97c128 Remove use strict directives in main vs code ts files
We compile using the alwaysStrict flag so these directives are not needed
2018-10-02 16:05:44 -07:00
Martin Aeschlimann 39bff6cf44 polish 2018-09-29 21:36:21 +02:00
Sandeep Somavarapu 9a6d9a0658 Fix args 2018-09-27 00:14:00 +02:00
Johannes Rieken 56dd8943ce fix #59216 2018-09-24 13:59:33 +02:00
Sandeep Somavarapu 588cfc8b68 #58965 Do not reinstall the extension 2018-09-24 09:37:10 +02:00
Johannes Rieken f6c98dfa5e remove console log, #58929 2018-09-21 15:10:35 +02:00
Johannes Rieken a2898d57fa implement chooseTab when connecting to the renderer, #58929 2018-09-21 15:10:35 +02:00
Johannes Rieken e25d7ddbf0 fail more graceful when a process cannot be profiled, #58929 2018-09-21 12:35:15 +02:00
Sandeep Somavarapu 1dd732608f Introduce --force arg to install extension without prompts 2018-09-13 12:14:37 +02:00
Benjamin Pasero 33693bcd1b debt - introduce and use sanitizeFilePath (#18837) 2018-09-05 14:58:12 +02:00
Benjamin Pasero 69e7247efd stop fs.realpath when opening so that symlinks are left intact (fixes #18837) 2018-09-04 14:05:43 +02:00
Benjamin Pasero 2466d395af first pass of WinJS.done() usage (for #57695) 2018-09-03 15:19:51 +02:00
Johannes Rieken 1420060f82 correct handshake to end profiling, related to #55675 2018-09-03 14:07:55 +02:00
Johannes Rieken 01ce593e96 improve error message and tell user to quit vscode first, #55675 2018-09-03 14:07:55 +02:00
Johannes Rieken daf9ca32d9 use random port for profiling ports, #55675 2018-09-03 14:07:55 +02:00
Johannes Rieken 2d452e0a7e uri - replace usages of default export with named export 2018-09-03 10:54:50 +02:00
Martin Aeschlimann 30d0a61a8f allow extensionDevelopmentPath to be a URI 2018-08-24 11:46:54 +02:00
Sandeep Somavarapu 45865de635 Merge branch 'master' into sandy081/syncExtensions 2018-08-21 13:00:54 +02:00
Sandeep Somavarapu 728e657c49 Make download service optional 2018-08-21 11:35:00 +02:00
Nikolai Vavilov aaa778b5e2 Use 'r+' with truncation when saving existing files on Windows (#42899)
* Use 'r+' with truncation when saving existing files on Windows

Opening a file with 'w' flag removes its alternate data streams. To
prevent this, extend the logic used for hidden files to all existing
files.

Fixes: https://github.com/Microsoft/vscode/issues/6363

* adopt truncate for saving as admin
2018-08-20 18:55:12 +02:00
Sandeep Somavarapu 8eb36b9cf4 fix compilation 2018-08-20 15:38:54 +02:00
Sandeep Somavarapu 9f492373ed - Use URI to install from vsix
- Implement zip and unzip extensions APIs
- Sync extension across management servers
- Download service to download zips
2018-08-20 15:16:40 +02:00
Martin Aeschlimann 1f1b778104 resource.isEqual / isEqualOrParent: use isIgnore default bahaviour 2018-08-20 12:10:08 +02:00
Martin Aeschlimann 8d9331a57c incorperate review comments 2018-08-13 12:09:34 +02:00