Johannes Rieken
09a758fb3f
refactor the new inline chat controller so that switching is simpler ( #239937 )
2025-02-07 14:08:52 +01:00
Johannes Rieken
d0b83e6142
support InlineChatRunOptions for inline chat ( #239591 )
2025-02-04 13:01:11 +01:00
Johannes Rieken
24f6dafe20
debt - remove inline chat preview mode ( #237654 )
2025-01-10 15:24:34 +01:00
Johannes Rieken
5555f6604d
inline hint for empty lines, right-click to hide, differentiate between empty line and suffix hint ( #234773 )
2024-11-27 09:08:40 -08:00
Johannes
f4bc95ae4f
fix https://github.com/microsoft/vscode-copilot/issues/10096
2024-11-26 11:31:43 +01:00
Johannes Rieken
eddef09fa7
renderer side inline hint and cmd to show/hide ( #234421 )
2024-11-22 15:36:09 +01:00
Benjamin Pasero
8a50c5f429
chat - cleanup global chat menu
2024-11-15 08:36:33 +01:00
Rob Lourens
50a2adc65b
Cleanup chat context keys ( #232515 )
...
* Start renaming context keys
* vote
* detected agent
* More
* More
* chatEditApplied
* More
* More
* More
* Cleanup
* Cleanup
2024-10-29 11:55:16 -07:00
Rob Lourens
9e5c728530
Use selected model in 'rerun' inline ( #232097 )
...
Fix microsoft/vscode-copilot#9618
2024-10-23 15:05:33 -07:00
Johannes Rieken
ec1125c2d1
inline chat fixes ( #229973 )
...
* disposing the editor view should remove overflowing overlay widgets node
* use a suitable overflow widget dom node for the inline chat widget
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4298
fixes (doesn't re-introduce) https://github.com/microsoft/vscode-copilot/issues/8701
* * make sure `ESC` first closes suggest before closing inline chat
* also remove duplicated action
2024-09-27 17:09:21 +02:00
Johannes Rieken
67a93b0e45
Revert "Revert "chat command center polish ( #229674 )" ( #229755 )" ( #229802 )
...
This reverts commit 11fb5bbfdb .
Add another context key `inlineChatPossible` which truely checks code editors so that a global command works
2024-09-26 11:11:36 +02:00
Connor Peet
11fb5bbfdb
Revert "chat command center polish ( #229674 )" ( #229755 )
...
This reverts commit b80272842e .
This broke sanity tests for copilot-chat, probably in preconditions
for `inlineChat.start`. It's not clear to me what the right fix is,
so I am backing it out in order to unblock copilot-chat.
2024-09-25 22:55:46 +02:00
Johannes Rieken
04d209954e
make sure cmd+i still works in notebooks ( #229680 )
2024-09-25 11:39:40 +02:00
Johannes Rieken
b80272842e
chat command center polish ( #229674 )
...
* mark `chat.commandCenter.enabled` as EXP setting, change default
* render keybindings
* order in buckets of panel, inline, and quick chat
2024-09-25 10:59:30 +02:00
Johannes Rieken
f8897bdb81
use dropdown with primary for chat command center ( #229136 )
2024-09-20 13:02:10 +02:00
Johannes Rieken
6f3c714dbe
removes inline chat content widget ( #227224 )
...
fixes https://github.com/microsoft/vscode/issues/227187
2024-08-30 16:59:56 +02:00
Benjamin Pasero
6b924c5152
ESM merge to main ( #227184 )
...
Co-authored-by: Johannes Rieken <jrieken@microsoft.com >
Co-authored-by: Alexandru Dima <alexdima@microsoft.com >
2024-08-30 10:31:46 +02:00
Johannes Rieken
2c24fee996
Polish UI of inline-edits toolbar ( #226969 )
...
* use lenses for accept/discard commands
* use lens actions for headless inline ui (and not right-aligned button bar)
* fixes https://github.com/microsoft/vscode/issues/226750
* fixes https://github.com/microsoft/vscode-copilot/issues/7628
* fixes https://github.com/microsoft/vscode-copilot/issues/7707
* fixes (maybe) https://github.com/microsoft/vscode-copilot/issues/7547
* fix https://github.com/microsoft/vscode/issues/226966
* graceful handling of headless run
2024-08-28 17:39:31 +02:00
Johannes Rieken
eb2f7c1a35
add secondary inline chat menu and render response commands there ( #226621 )
...
fixes https://github.com/microsoft/vscode-copilot/issues/7368
fixes https://github.com/microsoft/vscode-copilot/issues/6650
2024-08-26 16:06:26 +02:00
Johannes Rieken
cd09f4a11e
consider cancel state when recomputing response type context key ( #226409 )
...
re https://github.com/microsoft/vscode-copilot/issues/7324
2024-08-23 11:46:17 +02:00
Johannes Rieken
149a026ff9
show toggle diff in zone only when it applies ( #226257 )
2024-08-22 16:18:57 +02:00
Johannes Rieken
f12921b077
fixes https://github.com/microsoft/vscode-copilot/issues/7481 ( #226256 )
2024-08-22 16:18:40 +02:00
Johannes Rieken
6f13ec62fc
chore - inline chat work ( #226139 )
...
* chore - prepare inline chat to be started with an existing model that has edits
* debt - remove `SessionExchange` et al.
* Makes inline chat be entirely grounded in the chat model
* Removes the copy recordings command which never got used
2024-08-21 11:55:19 +02:00
Johannes Rieken
3b44b1102b
fix https://github.com/microsoft/vscode-copilot/issues/7326 ( #226065 )
2024-08-20 16:23:56 +02:00
Johannes Rieken
9330962d6b
use X icon for discard changes ( #226062 )
2024-08-20 15:55:01 +02:00
Johannes Rieken
469f45091d
add InlineChatController#reviewEdits which allows to reuse the inline code review flow/ui ( #225981 )
2024-08-19 17:51:14 +02:00
Johannes
4933da3c20
Revert "fix: resolve location data for rerun requests ( #225299 )"
...
This reverts commit 8723e832e6 .
2024-08-13 17:45:04 +02:00
Johannes Rieken
3218292d9d
remove ExpTextButtons setting and logic but keep make buttons more dynamic ( #225495 )
2024-08-13 16:00:26 +02:00
Joyce Er
8723e832e6
fix: resolve location data for rerun requests ( #225299 )
2024-08-09 15:26:09 -07:00
Rob Lourens
c21836e428
Enable cmd+up to focus chat list in terminal and inline chat widgets ( #224645 )
...
* Enable cmd+up to focus chat list in terminal and inline chat widgets
Fix #218088
* Clean up
2024-08-02 15:20:18 -07:00
Johannes Rieken
e5d157c069
Inline chat fixes ( #218318 )
...
* fix https://github.com/microsoft/vscode/issues/218059
* Change enablement of "Toggle Changes" instead of visibility
mitigates/fixes https://github.com/microsoft/vscode/issues/218099
* have padding per part (actions, input, list)
fixes https://github.com/microsoft/vscode/issues/218083
* fixes https://github.com/microsoft/vscode/issues/218021
* fix notebook button groups for inline chat
* tweak inline chat content widget when text btn are enabled
2024-06-26 13:18:47 +02:00
Johannes Rieken
d64446d9a2
filter send and cancel actions from execute toolbar ( #216801 )
...
* * fixes https://github.com/microsoft/vscode/issues/216692
* make text-btn with command but with a little color
* * don't show close/view-in-chat while request is in flight
* filter send and cancel actions from execute toolbar
fixes https://github.com/microsoft/vscode/issues/216772
2024-06-21 13:12:27 +02:00
Johannes Rieken
a11602734b
inline chat positioning polish ( #216630 )
...
* make sure to show close button when having just message responses
* * no more intented rendering of inline chat
* make sure the top of the view zone is always revealed
2024-06-19 18:10:43 +02:00
Johannes Rieken
88d860624c
Inline chat UI overhaul ( #215927 )
...
* don't dimiss inline chat content widget when already having typed something
https://github.com/microsoft/vscode-copilot/issues/6067
* extract `TextOnlyMenuEntryActionViewItem` for reuse
* remove unused variables
* * show chat input below request/response pairs
* setting for text-only buttons
* more dynamic buttons
* always show the first request, don't repopulate input with last message
* keep progress bar hidden, rely on "Generating..."
* no more special background color
* add `minimal` renderer style for chat renderings
* tweak font-size for details when render mode is minimal
* stable scroll position for inline chat, don't push down the lines chat is editing but push the inline chat upwards
* more buttons more compact, tweak labels
* * add missing service dependency
* repopulate input for some unit test
* allow output from `InteractiveChatController` suite
2024-06-17 11:26:21 +02:00
Johannes Rieken
c0bbf0447e
Cleanup and prepare inline chat for UI updates ( #215420 )
...
* 💄
* debt - remove `trackEdits` because we have fixup
debt - don't compute diff twice
* allow to pass/use all chat widget options when creating an inline chat widget
2024-06-13 11:24:50 +02:00
Johannes Rieken
b6c1b52bac
Remove configure inline chat command from menu because it isn't popular at all and takes space ( #213396 )
...
also fixes https://github.com/microsoft/vscode-copilot/issues/5662
2024-05-24 16:50:41 +02:00
Johannes Rieken
e67cdb56b1
clean up dead context keys and other dead code ( #213387 )
2024-05-24 14:07:41 +02:00
Johannes Rieken
a54e247fba
Enable roaming of inflight chat requests ( #213239 )
...
This enables to remove the special handling for `/explain`
- fixes https://github.com/microsoft/vscode-copilot/issues/2192
- fixes https://github.com/microsoft/vscode/issues/208706 because inline chat now closes on "view in chat"
- fixes https://github.com/microsoft/vscode-copilot/issues/5288
2024-05-22 18:47:03 +02:00
Johannes Rieken
95ffd765e1
chore - remove dead/stale commands ( #213207 )
2024-05-22 09:07:35 +02:00
Johannes Rieken
7680db2a11
Move rerun request back to prime spot, return with intent detection back as link ( #212775 )
...
* Bring back "Rerun Request" to its prominent spot
https://github.com/microsoft/vscode-copilot/issues/5604
* move rerun without gesture back into title
fixes https://github.com/microsoft/vscode-copilot/issues/5275
2024-05-15 09:31:04 +02:00
Megan Rogge
00bc1553ba
create AccessibleViewRegistry, move all applicable views/accessibility help dialogs over to use it ( #212138 )
2024-05-07 05:48:04 +02:00
Johannes Rieken
10a1ae8d6c
fix https://github.com/microsoft/vscode-copilot/issues/5342 ( #211295 )
2024-04-24 23:41:55 +02:00
Johannes Rieken
7d04d4df43
only have one report bug command ( #210802 )
2024-04-20 01:34:57 +02:00
Johannes Rieken
6a06de0033
Hook up feedback/user-action events for inline chat participants ( #210040 )
...
- add a special user-action
- inline chat controller doesn't call handleFeedback directly anymore
- ReplyResonse knows its chat model response
2024-04-10 13:15:40 +02:00
Johannes Rieken
ef6345ae05
Support for attempt and enableCommandDetection in chat model/service ( #209826 )
...
* add `IChatRequestModel#attempt` so that rerun request/response can be supported
* - support to run with/without command detection enabled
- adopt agent brigde to new chat request
- add share rerun-commands (but only enable them for inline chat for now)
2024-04-08 14:08:22 +02:00
Johannes Rieken
1d1c28eed1
Cleanup some inline chat debt ( #209009 )
...
* - make inline chat tab-able (fixes https://github.com/microsoft/vscode/issues/208569 )
- fix aria label
* - move report issue into widget toolbar
- some todo-cleanup
* remove unused menuid
2024-03-28 13:07:01 +01:00
Johannes Rieken
9757f7c73a
Make "Toggle Changes" more prominent and re-run less ( #208917 )
...
- add regenerage and regenerate w/o intent detection to response title menu
- have toggle changes command with accept and discard
- add context key for chat widget location
2024-03-27 17:30:18 +01:00
Johannes Rieken
b37d8bc51f
show inline chat content widget below the selection ( #208907 )
...
* let close cancel/discard a vanilla inline chat session
fixes https://github.com/microsoft/vscode/issues/208585
* show inline chat content widget below the selection
https://github.com/microsoft/vscode/issues/208597
2024-03-27 15:26:11 +01:00
Johannes
ebfbf27d8c
- fix layout bugs
...
- enable terminal history with new world
- fix (most) command group associations
2024-03-21 11:58:28 +01:00
Johannes
6ae696aa56
- first run of cleanup
...
- update new required services for tests and adjust them
2024-03-20 15:58:55 +01:00