Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 10:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity
129,479 Commits 3,657 Branches 358 Tags
09a758fb3ff4f1098e2ad6dcdb64d1683b6b099c
Commit Graph

53 Commits

Author SHA1 Message Date
Johannes
3aece83761 wip - inline chat via editing session 2025-01-22 09:13:23 +01:00
Johannes Rieken
a0af0335c8 chore - cleanup (#238118) 2025-01-17 12:10:00 +01:00
Johannes Rieken
24f6dafe20 debt - remove inline chat preview mode (#237654) 2025-01-10 15:24:34 +01:00
Johannes Rieken
0da229afca no width restriction for inline chat (#234975) 
fixes https://github.com/microsoft/vscode-copilot/issues/9266
 2024-12-02 12:51:10 +01:00
Johannes Rieken
c0699e2945 Joh/sweet-crawdad (#234851) 
* fix empty line hint

* no ellipsis on hints

* add `renderDetectedCommandsWithRequest` option and use it for inline chat

fyi @roblourens
 2024-11-28 17:31:08 +01:00
Johannes Rieken
0401bcef46 render rerun message for detected commands with actions (#234747) 
https://github.com/microsoft/vscode-copilot/issues/10751

fyi @joyceerhl this fixes an issue where detected commands weren't advertised as such
 2024-11-27 12:12:16 +01:00
Johannes Rieken
f9a75f1418 inline chat fixes (#233566) 
* take decorationWidth into account when layouting chat zone

https://github.com/microsoft/vscode/issues/233561

* chat - fix input height computation when resizing editor
 2024-11-11 11:42:18 +01:00
Johannes Rieken
d5bdaaa0c0 full width inline zone (#233215) 
fixes https://github.com/microsoft/vscode/issues/233201#issuecomment-2460048937
 2024-11-06 17:04:12 +01:00
Johannes Rieken
3ee667af42 allow wider width, fix an issue with dropped resized height (#232814) 
* remove dead code

* allow wider width, fix an issue with dropped resized height
 2024-11-01 05:20:23 -07:00
Johannes Rieken
702e6b8155 inline chat should not bleed into scroll bar (#232812) 2024-11-01 13:19:38 +01:00
Johannes Rieken
08dbf783fc allow to resize inline chat zone (#232795) 
* * make inline chat filter empty in-progress items
* show ellipses progress on request
* make inline zone animate its frame during request

* allow to resize inline chat zone

fixes https://github.com/microsoft/vscode/issues/230784
 2024-11-01 02:01:56 -07:00
Johannes Rieken
ad047e27d5 tweak editor inline chat visuals (#230521) 
...to be more aligned with other peek experiences, like peek ref or edit breakpoint
 2024-10-04 10:47:00 -07:00
Johannes Rieken
ded5e0d79e counter revealLines-logic with sticky scroll max lines (#229939) 
fixes https://github.com/microsoft/vscode/issues/229934
 2024-09-27 11:48:08 +02:00
Johannes Rieken
178c125fe2 reveal chat zone should always reveal position in editor (#229838) 
fixes https://github.com/microsoft/vscode-copilot/issues/8509
 2024-09-26 16:58:27 +02:00
Rob Lourens
3be54cca5b Split input actions, move attachments inside chat input (#228684) 
* Rearrange buttons

* Fix compact chat

* Fix
 2024-09-15 16:41:01 -07:00
Johannes Rieken
edbf964e42 ensure accept/discard always reveals the zone widget (#228327) 
fixes https://github.com/microsoft/vscode-copilot/issues/7933
 2024-09-12 11:49:10 +02:00
Johannes Rieken
f32768e487 stop inline chat reveal on any vertical scroll (#227220) 
https://github.com/microsoft/vscode-copilot/issues/7338
 2024-08-30 16:19:41 +02:00
Benjamin Pasero
6b924c5152 ESM merge to main (#227184) 
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
 2024-08-30 10:31:46 +02:00
Johannes Rieken
cf26b311e6 stop scrolling/revealing inline chat if "scrolling up" happened (#227055) 
fixes https://github.com/microsoft/vscode-copilot/issues/7550
 2024-08-29 12:27:22 +02:00
Johannes Rieken
eb2f7c1a35 add secondary inline chat menu and render response commands there (#226621) 
fixes https://github.com/microsoft/vscode-copilot/issues/7368
fixes https://github.com/microsoft/vscode-copilot/issues/6650
 2024-08-26 16:06:26 +02:00
Johannes Rieken
f7cc48cd7c restore zone top only when not having been scrolled out already (#226395) 
fixes https://github.com/microsoft/vscode-copilot/issues/7338
 2024-08-23 10:29:48 +02:00
Johannes Rieken
95608e3202 use bigger than default ordinal for inline zone (#226152) 
re https://github.com/microsoft/vscode-copilot/issues/7355
 2024-08-21 13:39:58 +02:00
Johannes Rieken
3b44b1102b fix https://github.com/microsoft/vscode-copilot/issues/7326 (#226065) 2024-08-20 16:23:56 +02:00
Johannes Rieken
3218292d9d remove ExpTextButtons setting and logic but keep make buttons more dynamic (#225495) 2024-08-13 16:00:26 +02:00
Johannes Rieken
ecf818849d add location specific data along when making chat request (#219114) 
with this PR the implicit variables tricks aren't needed anymore
 2024-06-28 16:27:08 +02:00
Johannes Rieken
d64446d9a2 filter send and cancel actions from execute toolbar (#216801) 
* * fixes https://github.com/microsoft/vscode/issues/216692
* make text-btn with command but with a little color

* * don't show close/view-in-chat while request is in flight

* filter send and cancel actions from execute toolbar

fixes https://github.com/microsoft/vscode/issues/216772
 2024-06-21 13:12:27 +02:00
Johannes Rieken
63d0666760 fix https://github.com/microsoft/vscode/issues/216791 (#216794) 2024-06-21 11:25:42 +02:00
Johannes Rieken
07dcb7aff4 inline chat stable scroll should ensure first line stays visible (#216705) 2024-06-20 13:05:30 +02:00
Johannes Rieken
a11602734b inline chat positioning polish (#216630) 
* make sure to show close button when having just message responses

* * no more intented rendering of inline chat
* make sure the top of the view zone is always revealed
 2024-06-19 18:10:43 +02:00
Johannes Rieken
88d860624c Inline chat UI overhaul (#215927) 
* don't dimiss inline chat content widget when already having typed something

https://github.com/microsoft/vscode-copilot/issues/6067

* extract `TextOnlyMenuEntryActionViewItem` for reuse

* remove unused variables

* * show chat input below request/response pairs
* setting for text-only buttons
* more dynamic buttons
* always show the first request, don't repopulate input with last message
* keep progress bar hidden, rely on "Generating..."
* no more special background color

* add `minimal` renderer style for chat renderings

* tweak font-size for details when render mode is minimal

* stable scroll position for inline chat, don't push down the lines chat is editing but push the inline chat upwards

* more buttons more compact, tweak labels

* * add missing service dependency
* repopulate input for some unit test

* allow output from `InteractiveChatController` suite
 2024-06-17 11:26:21 +02:00
Johannes Rieken
c0bbf0447e Cleanup and prepare inline chat for UI updates (#215420) 
* 💄

* debt - remove `trackEdits` because we have fixup
debt - don't compute diff twice

* allow to pass/use all chat widget options when creating an inline chat widget
 2024-06-13 11:24:50 +02:00
Johannes Rieken
826a005eae improve zone revealing when showing above line 1 (#213904) 
fixes https://github.com/microsoft/vscode/issues/213822
 2024-05-30 14:52:34 +02:00
Benjamin Pasero
6dc91d8985 closing out inline chat while speech is going does not stop audio (fix #213709) (#213802) 2024-05-29 14:29:00 +02:00
Johannes Rieken
a5e41db5c7 inline chat for notebook cell uses the Notebook chat location (#213385) 
* inline chat for notebook cell uses the `Notebook` chat location

* fix tests
 2024-05-24 14:10:49 +02:00
Johannes Rieken
a54e247fba Enable roaming of inflight chat requests (#213239) 
This enables to remove the special handling for `/explain`

- fixes https://github.com/microsoft/vscode-copilot/issues/2192
- fixes https://github.com/microsoft/vscode/issues/208706 because inline chat now closes on "view in chat"
- fixes https://github.com/microsoft/vscode-copilot/issues/5288
 2024-05-22 18:47:03 +02:00
Johannes Rieken
743fdd9587 focus owning editor when clicking into zone without having editor widget focus (#212878) 
fixes https://github.com/microsoft/vscode-copilot/issues/5410
 2024-05-16 17:04:59 +02:00
Johannes Rieken
db964c5e69 chore - remove dead code (#211946) 2024-05-03 16:27:09 +02:00
Johannes Rieken
7b91c2d1ba Live mode uses chat widget rendering (#210157) 
* reveal editor after making changes

* also give preview models a path component

* workaround errors in diff computer fyi @hediet

* * make live mode be a rendering mode
* render new files with the chat widget and not with a separate zone

* 💄

* fix tests
 2024-04-11 14:43:53 +02:00
Johannes Rieken
47fc35d216 add StableEditorBottomScrollState so that inline chat moves lines of interest less (#209637) 
there is still some movement because the height of the zone changes through out the request
 2024-04-05 16:02:52 +02:00
Johannes
5b1b744590 - extract IChatListItemRendererOptions 
- use diff editor hiding of unchanged regions
- simpler code compare block (for now)
 2024-04-04 11:51:06 +02:00
Johannes Rieken
1d1c28eed1 Cleanup some inline chat debt (#209009) 
* - make inline chat tab-able (fixes https://github.com/microsoft/vscode/issues/208569)
- fix aria label

* - move report issue into widget toolbar
- some todo-cleanup

* remove unused menuid
 2024-03-28 13:07:01 +01:00
Johannes Rieken
9757f7c73a Make "Toggle Changes" more prominent and re-run less (#208917) 
- add regenerage and regenerate w/o intent detection to response title menu
- have toggle changes command with accept and discard
- add context key for chat widget location
 2024-03-27 17:30:18 +01:00
Johannes Rieken
631514ae58 don't use ICodeEditor#getOffsetForColumn for lines that aren't rendered (#208896) 
fixes https://github.com/microsoft/vscode-copilot/issues/4828
 2024-03-27 12:33:56 +01:00
Johannes Rieken
7a3a29fee3 Assorted inline chat fixes (#208769) 
* fix/workaround https://github.com/microsoft/vscode/issues/208549

* fixes https://github.com/microsoft/vscode/issues/208656

* add minHeight to inline chat widget

fixes https://github.com/microsoft/vscode-copilot/issues/4770

* fixes https://github.com/microsoft/vscode/issues/208606

* only honor `refer` flag when its command is the first and only

fixes https://github.com/microsoft/vscode/issues/208574
 2024-03-26 12:38:26 +01:00
Johannes
ebfbf27d8c - fix layout bugs 
- enable terminal history with new world
- fix (most) command group associations
 2024-03-21 11:58:28 +01:00
Johannes
1f17652159 - only layout zone widget when visible 
- content widget and controller tweaks
- wire up follow up commands
- disable filter for inline chat widget because its weird
- hardcode height
 2024-03-19 14:31:53 +01:00
Johannes
45f50d555e - tweak content height and layouting challenges 
- filter first request
 2024-03-18 12:45:43 +01:00
Johannes
0ac95cc1b7 - use chat input part for content widget 
- use chat widget over renderer-reuse and custom input
- allow to configure chat menus/actions
- allow to define filter for chat list/tree
 2024-03-15 15:44:41 +01:00
Johannes Rieken
080f9685c0 update layout logic (#207687) 2024-03-14 10:21:41 +01:00
Johannes Rieken
74020cb0cc Inline chat content overlay (#207415) 
* add inline chat content widget for first interaction

* better layout of the inline chat content widget

* fix alignment of toolbars when having multiline inputs

* set width of progress bar

* more size tweaking
 2024-03-12 14:24:00 +01:00